From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: kirkwood: kirkwood_pm_init() should return void
Date: Fri, 17 Jan 2014 23:18:09 +0100 [thread overview]
Message-ID: <20140117221809.GW17530@lunn.ch> (raw)
In-Reply-To: <1389984731-20220-1-git-send-email-ezequiel.garcia@free-electrons.com>
On Fri, Jan 17, 2014 at 03:52:11PM -0300, Ezequiel Garcia wrote:
> This function was originally meant to return void as declared in the
> common.h header. Fix it and include the header to catch these errors
> in the future.
>
> Reported-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Acked-by: Andrew Lunn <andrew@lunn.ch>
Andrew
> ---
> arch/arm/mach-kirkwood/pm.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-kirkwood/pm.c b/arch/arm/mach-kirkwood/pm.c
> index 8783a71..c11f7f5 100644
> --- a/arch/arm/mach-kirkwood/pm.c
> +++ b/arch/arm/mach-kirkwood/pm.c
> @@ -18,6 +18,7 @@
> #include <linux/suspend.h>
> #include <linux/io.h>
> #include <mach/bridge-regs.h>
> +#include "common.h"
>
> static void __iomem *ddr_operation_base;
>
> @@ -65,7 +66,7 @@ static const struct platform_suspend_ops kirkwood_suspend_ops = {
> .valid = kirkwood_pm_valid_standby,
> };
>
> -int __init kirkwood_pm_init(void)
> +void __init kirkwood_pm_init(void)
> {
> ddr_operation_base = ioremap(DDR_OPERATION_BASE, 4);
> suspend_set_ops(&kirkwood_suspend_ops);
> --
> 1.8.1.5
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2014-01-17 22:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-17 18:52 [PATCH] ARM: kirkwood: kirkwood_pm_init() should return void Ezequiel Garcia
2014-01-17 22:18 ` Andrew Lunn [this message]
2014-01-18 23:54 ` Jason Cooper
2014-01-19 0:29 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140117221809.GW17530@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).