From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: kirkwood: kirkwood_pm_init() should return void
Date: Sat, 18 Jan 2014 21:29:53 -0300 [thread overview]
Message-ID: <20140119002952.GA2412@localhost> (raw)
In-Reply-To: <20140118235411.GN29184@titan.lakedaemon.net>
On Sat, Jan 18, 2014 at 06:54:11PM -0500, Jason Cooper wrote:
> On Fri, Jan 17, 2014 at 03:52:11PM -0300, Ezequiel Garcia wrote:
> > This function was originally meant to return void as declared in the
> > common.h header. Fix it and include the header to catch these errors
> > in the future.
> >
> > Reported-by: Andrew Lunn <andrew@lunn.ch>
> > Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> > ---
> > arch/arm/mach-kirkwood/pm.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
>
> merf. I get the following warning when building kirkwood_defconfig:
>
> arch/arm/mach-kirkwood/pm.c: In function 'kirkwood_pm_init':
> arch/arm/mach-kirkwood/pm.c:73:2: warning: 'return' with a value, in function returning void [enabled by default]
>
Doh...
> I've amended the patch as below and pushed it to mvebu/fixes
>
Thanks!
--
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
prev parent reply other threads:[~2014-01-19 0:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-17 18:52 [PATCH] ARM: kirkwood: kirkwood_pm_init() should return void Ezequiel Garcia
2014-01-17 22:18 ` Andrew Lunn
2014-01-18 23:54 ` Jason Cooper
2014-01-19 0:29 ` Ezequiel Garcia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140119002952.GA2412@localhost \
--to=ezequiel.garcia@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).