From mboxrd@z Thu Jan 1 00:00:00 1970 From: vinod.koul@intel.com (Vinod Koul) Date: Mon, 20 Jan 2014 13:12:05 +0530 Subject: [PATCH] dma: imx-sdma: remove firmare not found warning In-Reply-To: <1389887186-6146-1-git-send-email-s.hauer@pengutronix.de> References: <1389887186-6146-1-git-send-email-s.hauer@pengutronix.de> Message-ID: <20140120074205.GG26823@intel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Jan 16, 2014 at 04:46:26PM +0100, Sascha Hauer wrote: > When a firmware cannot be found for the SDMA engine then we can > continue with the inernal ROM firmware. typo ^^^^^^^ > The meaning of this message is frequently asked for and the usual > answer is that this message is of no relevance, so just make it > dev_dbg() and do not alienate the users anymore. > > Signed-off-by: Sascha Hauer > Cc: Vinod Koul > --- > drivers/dma/imx-sdma.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c > index c75679d..fe57a42 100644 > --- a/drivers/dma/imx-sdma.c > +++ b/drivers/dma/imx-sdma.c > @@ -1259,7 +1259,10 @@ static void sdma_load_firmware(const struct firmware *fw, void *context) > unsigned short *ram_code; > > if (!fw) { > - dev_err(sdma->dev, "firmware not found\n"); > + dev_dbg(sdma->dev, "firmware not found\n"); Shouldn't this be dev_info and would amke sense, external firmware not found using internal one?? -- ~Vinod > + /* > + * In this case we just use the ROM firmware. > + */ > return; > } > > -- > 1.8.5.2 > --