linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dma: imx-sdma: remove firmare not found warning
Date: Mon, 20 Jan 2014 11:07:09 +0100	[thread overview]
Message-ID: <20140120100709.GN16215@pengutronix.de> (raw)
In-Reply-To: <20140120074205.GG26823@intel.com>

On Mon, Jan 20, 2014 at 01:12:05PM +0530, Vinod Koul wrote:
> On Thu, Jan 16, 2014 at 04:46:26PM +0100, Sascha Hauer wrote:
> > When a firmware cannot be found for the SDMA engine then we can
> > continue with the inernal ROM firmware.
> typo		    ^^^^^^^
> 
> > The meaning of this message is frequently asked for and the usual
> > answer is that this message is of no relevance, so just make it
> > dev_dbg() and do not alienate the users anymore.
> > 
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > Cc: Vinod Koul <vinod.koul@intel.com>
> > ---
> >  drivers/dma/imx-sdma.c | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> > index c75679d..fe57a42 100644
> > --- a/drivers/dma/imx-sdma.c
> > +++ b/drivers/dma/imx-sdma.c
> > @@ -1259,7 +1259,10 @@ static void sdma_load_firmware(const struct firmware *fw, void *context)
> >  	unsigned short *ram_code;
> >  
> >  	if (!fw) {
> > -		dev_err(sdma->dev, "firmware not found\n");
> > +		dev_dbg(sdma->dev, "firmware not found\n");
> Shouldn't this be dev_info and would amke sense, external firmware not found
> using internal one??

Yeah, sounds better. See v2.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

      reply	other threads:[~2014-01-20 10:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-16 15:46 [PATCH] dma: imx-sdma: remove firmare not found warning Sascha Hauer
2014-01-17  6:10 ` Shawn Guo
2014-01-20  7:42 ` Vinod Koul
2014-01-20 10:07   ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140120100709.GN16215@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).