From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dma: fix vchan_cookie_complete() debug print
Date: Mon, 20 Jan 2014 17:33:01 +0530 [thread overview]
Message-ID: <20140120120301.GE26823@intel.com> (raw)
In-Reply-To: <20140120112822.GA15937@n2100.arm.linux.org.uk>
On Mon, Jan 20, 2014 at 11:28:22AM +0000, Russell King - ARM Linux wrote:
> On Mon, Jan 20, 2014 at 03:29:17PM +0530, Vinod Koul wrote:
> > On Fri, Dec 06, 2013 at 04:42:09PM +0100, Jonas Jensen wrote:
> > > vd->tx.cookie is set zero on dma_cookie_complete(),
> > > save to local before printing it.
> > >
> > > Signed-off-by: Jonas Jensen <jonas.jensen@gmail.com>
> > > ---
> > >
> > > Notes:
> > > dev_vdbg() could also be moved to happen earlier, what do you prefer?
> > This would be preferred IMHO. Also pls cc dmaengine at vger on this
>
> I prefer this version - it means that the verbose debug printk doesn't
> impact the completion timing when printk is expensive (eg, because its
> outputting via a serial port.)
But if you know your printk is costly, do you want to enable these?
--
~Vinod
next prev parent reply other threads:[~2014-01-20 12:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 15:42 [PATCH] dma: fix vchan_cookie_complete() debug print Jonas Jensen
2013-12-06 17:20 ` Dan Williams
2013-12-09 9:25 ` [PATCH v2] " Jonas Jensen
2014-01-20 10:00 ` Vinod Koul
2014-01-20 9:59 ` [PATCH] " Vinod Koul
2014-01-20 11:28 ` Russell King - ARM Linux
2014-01-20 12:03 ` Vinod Koul [this message]
2014-01-20 13:28 ` Russell King - ARM Linux
2014-01-26 11:23 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140120120301.GE26823@intel.com \
--to=vinod.koul@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).