From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/5] clk: versatile: respect parent rate in ICST clock
Date: Mon, 20 Jan 2014 21:33:27 +0000 [thread overview]
Message-ID: <20140120213327.GK15937@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CACRpkdZ1F_SvGcerMDfmhSgnLVzLXBJnQ9iftSG6yW2mMhOOKQ@mail.gmail.com>
On Mon, Jan 20, 2014 at 10:16:53PM +0100, Linus Walleij wrote:
> On Mon, Jan 20, 2014 at 10:12 PM, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
>
> >> -static const struct icst_params impd1_vco2_params = {
> >> +static struct icst_params impd1_vco2_params = {
> >> .ref = 24000000, /* 24 MHz */
> >> .vco_max = ICST525_VCO_MAX_3V,
> >> .vco_min = ICST525_VCO_MIN,
> >
> > Right, so we end up writing directly into these _shared_ _statically_
> > _allocated_ structures.
>
> Argh yeah that's right.
>
> I'll think of something better, like allocating the params on-the-fly
> for DT instead.
That's actually why they're const - they're const because they are not
supposed to be written to...
--
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".
prev parent reply other threads:[~2014-01-20 21:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-20 20:55 [PATCH 5/5] clk: versatile: respect parent rate in ICST clock Linus Walleij
2014-01-20 21:12 ` Russell King - ARM Linux
2014-01-20 21:16 ` Linus Walleij
2014-01-20 21:33 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140120213327.GK15937@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox