* Nomadik clk not MULTI_V5 friendly
@ 2014-01-20 22:01 Andrew Lunn
2014-01-21 8:07 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Lunn @ 2014-01-20 22:01 UTC (permalink / raw)
To: linux-arm-kernel
Hi Linus
drivers/clk/clk-nomadik.c:
static int __init nomadik_src_clk_init_debugfs(void)
{
src_pcksr0_boot = readl(src_base + SRC_PCKSR0);
src_pcksr1_boot = readl(src_base + SRC_PCKSR1);
debugfs_create_file("nomadik-src-clk", S_IFREG | S_IRUGO,
NULL, NULL, &nomadik_src_clk_debugfs_ops);
return 0;
}
module_init(nomadik_src_clk_init_debugfs);
It does not check if it is actually running on a Nomadik, so when this
module_init() is executed on kirkwood as part of a MULTI_V5 kernel,
bad things happen. Please could you add the necessary check.
Thanks
Andrew
^ permalink raw reply [flat|nested] 2+ messages in thread
* Nomadik clk not MULTI_V5 friendly
2014-01-20 22:01 Nomadik clk not MULTI_V5 friendly Andrew Lunn
@ 2014-01-21 8:07 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2014-01-21 8:07 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jan 20, 2014 at 11:01 PM, Andrew Lunn <andrew@lunn.ch> wrote:
> It does not check if it is actually running on a Nomadik, so when this
> module_init() is executed on kirkwood as part of a MULTI_V5 kernel,
> bad things happen. Please could you add the necessary check.
Sure, fixed it, can you test and provide your Tested-by tag to Mike
so he can merge it?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-01-21 8:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-20 22:01 Nomadik clk not MULTI_V5 friendly Andrew Lunn
2014-01-21 8:07 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).