From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 09/15] watchdog: orion: Add per-compatible clock initialization
Date: Tue, 21 Jan 2014 06:43:14 -0300 [thread overview]
Message-ID: <20140121094313.GB3577@localhost> (raw)
In-Reply-To: <CAOMZO5BDS8Dh1PR6SJv1CK5Pkq5mub-Hs7c4RhxUn7o5efnbKg@mail.gmail.com>
On Tue, Jan 21, 2014 at 07:18:44AM -0200, Fabio Estevam wrote:
> On Tue, Jan 21, 2014 at 7:12 AM, Ezequiel Garcia
> <ezequiel.garcia@free-electrons.com> wrote:
>
> > +static int orion_wdt_clock_init(struct platform_device *pdev,
> > + struct orion_watchdog *dev)
> > +{
> > + dev->clk = devm_clk_get(&pdev->dev, NULL);
> > + if (IS_ERR(dev->clk))
> > + return -ENODEV;
>
> Shouldn't it be 'return PTR_ERR(dev->clk)' instead?
>
>
[..]
> > + clk_prepare_enable(dev->clk);
>
> clk_prepare_enable may fail, so better check its return value.
>
Indeed.
Thanks!
--
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-01-21 9:43 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-21 9:12 [PATCH v2 00/15] Armada 370/XP watchdog support Ezequiel Garcia
2014-01-21 9:12 ` [PATCH v2 01/15] ARM: Introduce atomic MMIO modify Ezequiel Garcia
2014-01-21 9:45 ` Arnd Bergmann
2014-01-21 10:46 ` Ezequiel Garcia
2014-01-21 9:12 ` [PATCH v2 02/15] clocksource: orion: Use atomic access for shared registers Ezequiel Garcia
2014-01-21 9:46 ` Arnd Bergmann
2014-01-21 9:58 ` Sebastian Hesselbarth
2014-01-21 10:54 ` Arnd Bergmann
2014-01-21 11:02 ` Andrew Lunn
2014-01-21 9:57 ` Daniel Lezcano
2014-01-21 10:53 ` Ezequiel Garcia
2014-01-21 9:12 ` [PATCH v2 03/15] watchdog: " Ezequiel Garcia
2014-01-21 9:19 ` Fabio Estevam
2014-01-21 9:42 ` Ezequiel Garcia
2014-01-21 9:54 ` Arnd Bergmann
2014-01-21 10:13 ` Andrew Lunn
2014-01-21 9:12 ` [PATCH v2 04/15] watchdog: orion: Handle IRQ Ezequiel Garcia
2014-01-21 9:12 ` [PATCH v2 05/15] watchdog: orion: Make RSTOUT register a separate resource Ezequiel Garcia
2014-01-21 23:33 ` Jason Gunthorpe
2014-01-22 9:48 ` Arnd Bergmann
2014-01-22 16:21 ` Ezequiel Garcia
2014-01-22 18:01 ` Ezequiel Garcia
2014-01-22 18:14 ` Jason Gunthorpe
2014-01-22 18:21 ` Arnd Bergmann
2014-01-22 18:29 ` Ezequiel Garcia
2014-01-21 9:12 ` [PATCH v2 06/15] watchdog: orion: Remove unneeded BRIDGE_CAUSE clear Ezequiel Garcia
2014-01-21 23:35 ` Jason Gunthorpe
2014-01-22 16:49 ` Ezequiel Garcia
2014-01-22 17:34 ` Jason Gunthorpe
2014-01-22 17:45 ` Ezequiel Garcia
2014-01-22 17:50 ` Jason Gunthorpe
2014-01-22 18:03 ` Ezequiel Garcia
2014-01-22 20:31 ` Sebastian Hesselbarth
2014-01-22 20:52 ` Jason Gunthorpe
2014-01-22 22:12 ` Ezequiel Garcia
2014-01-22 22:31 ` Jason Gunthorpe
2014-01-22 22:56 ` Ezequiel Garcia
2014-01-23 0:03 ` Sebastian Hesselbarth
2014-01-23 0:19 ` Jason Gunthorpe
2014-01-23 0:35 ` Sebastian Hesselbarth
2014-01-23 12:04 ` Ezequiel Garcia
2014-01-22 23:49 ` Sebastian Hesselbarth
2014-01-23 11:10 ` Ezequiel Garcia
2014-01-23 11:54 ` Ezequiel Garcia
2014-01-23 21:15 ` Sebastian Hesselbarth
2014-01-21 9:12 ` [PATCH v2 07/15] watchdog: orion: Introduce an orion_watchdog device structure Ezequiel Garcia
2014-01-21 9:12 ` [PATCH v2 08/15] watchdog: orion: Introduce per-compatible of_device_id data Ezequiel Garcia
2014-01-21 9:12 ` [PATCH v2 09/15] watchdog: orion: Add per-compatible clock initialization Ezequiel Garcia
2014-01-21 9:18 ` Fabio Estevam
2014-01-21 9:43 ` Ezequiel Garcia [this message]
2014-01-21 9:12 ` [PATCH v2 10/15] watchdog: orion: Add per-compatible watchdog start implementation Ezequiel Garcia
2014-01-21 9:12 ` [PATCH v2 11/15] watchdog: orion: Add support for Armada 370 and Armada XP SoC Ezequiel Garcia
2014-01-21 9:12 ` [PATCH v2 12/15] ARM: mvebu: Enable Armada 370/XP watchdog in the devicetree Ezequiel Garcia
2014-01-21 9:12 ` [PATCH v2 13/15] ARM: kirkwood: Add RSTOUT 'reg' entry to devicetree Ezequiel Garcia
2014-01-21 9:12 ` [PATCH v2 14/15] watchdog: orion: Allow to build on any Orion platform Ezequiel Garcia
2014-01-21 9:41 ` Sebastian Hesselbarth
2014-01-21 9:45 ` Andrew Lunn
2014-01-21 10:04 ` Ezequiel Garcia
2014-01-21 11:06 ` Removing PLAT_ORION dependency from ARCH_MVEBU (Was Re: [PATCH v2 14/15] watchdog: orion: Allow to build on any Orion platform) Ezequiel Garcia
2014-01-21 11:44 ` Sebastian Hesselbarth
2014-01-21 9:12 ` [PATCH v2 15/15] ARM: mvebu: Enable watchdog support in defconfig Ezequiel Garcia
2014-01-21 12:47 ` Jason Cooper
2014-01-21 12:53 ` Andrew Lunn
2014-01-21 12:57 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140121094313.GB3577@localhost \
--to=ezequiel.garcia@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).