[PATCH v2] dma: imx-sdma: clarify firmare not found warning

Lothar Waßmann
2014-01-21T08:31:07Z

Hi,

Sascha Hauer wrote:
> Hi Lothar,
>
> On Mon, Jan 20, 2014 at 12:36:27PM +0100, Lothar Wa?mann wrote:
> > Hi,
> >
> > Lothar Wa?mann wrote:
> > > Hi,
> > >
> > erroneously pressed the 'Send' button...
> >
> > > Sascha Hauer wrote:
> > > > When a firmware cannot be found for the SDMA engine then we can
> > > > continue with the inernal ROM firmware.
> > > >
> > > > The meaning of this message is frequently asked for, so make clear
> > > > that the driver still works with the internal ROM firmware and reduce
> > > > the loglevel from err to info.
> > > >
> > In case user space firmware loading support (CONFIG_FW_LOADER) is
> > enabled, this message may still be inadequate, since the firmware may
> > very well be loaded lateron.
>
> Then at least until the RAM firmware is loaded the message is still adequate,
> no? We could add an addional message when the firmware is loaded if you
> like.
>
There is already a message printed upon successful firmware load:
|imx-sdma 63fb0000.sdma: loaded firmware 1.1

But one message saying 'firmware load failed' and another saying the
opposite is a bit confusing. There actually is also a message saying
'firmware not found' when the timeout expires without any firmware
being loaded. Thus at least in case CONFIG_FW_LOADER is enabled the
message 'Direct firmware load failed' could be omitted.

Lothar Wa?mann
--
___________________________________________________________

Ka-Ro electronics GmbH | Pascalstra?e 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Gesch?ftsf?hrer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | info at karo-electronics.de
___________________________________________________________