From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 5/6] misc: debug: remove compilation warnings
Date: Wed, 22 Jan 2014 16:11:53 +0000 [thread overview]
Message-ID: <20140122161152.GD8065@arm.com> (raw)
In-Reply-To: <1390401773-12100-6-git-send-email-vijay.kilari@gmail.com>
On Wed, Jan 22, 2014 at 02:42:52PM +0000, vijay.kilari at gmail.com wrote:
> From: Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
>
> Resolve following compiler warnings
> warning: format '%lx' expects argument of type 'long unsigned int',
> but argument 2 has type 'u64' [-Wformat]
>
> tested for warnings on arm32 & arm64
>
> Signed-off-by: Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
> ---
> drivers/misc/kgdbts.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/misc/kgdbts.c b/drivers/misc/kgdbts.c
> index 36f5d52..78e10b2 100644
> --- a/drivers/misc/kgdbts.c
> +++ b/drivers/misc/kgdbts.c
> @@ -350,8 +350,8 @@ static int check_single_step(char *put_str, char *arg)
> kgdb_hex2mem(&put_str[1], (char *)kgdbts_gdb_regs,
> NUMREGBYTES);
> gdb_regs_to_pt_regs(kgdbts_gdb_regs, &kgdbts_regs);
> - v2printk("Singlestep stopped at IP: %lx\n",
> - instruction_pointer(&kgdbts_regs));
> + v2printk("Singlestep stopped at IP: %llx\n",
> + (unsigned long long)instruction_pointer(&kgdbts_regs));
>
> if (sstep_thread_id != cont_thread_id) {
> /*
> @@ -376,8 +376,8 @@ static int check_single_step(char *put_str, char *arg)
> continue_test:
> matched_id = 0;
> if (instruction_pointer(&kgdbts_regs) == addr) {
> - eprintk("kgdbts: SingleStep failed at %lx\n",
> - instruction_pointer(&kgdbts_regs));
> + eprintk("kgdbts: SingleStep failed at %llx\n",
> + (unsigned long long)instruction_pointer(&kgdbts_regs));
I think we could simply add the cast to the definition of
instruction_pointer() on arm64. Even the generic instruction_pointer()
definition returns unsigned long.
--
Catalin
next prev parent reply other threads:[~2014-01-22 16:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-22 14:42 [PATCH v7 0/6] arm64: KGDB Support vijay.kilari at gmail.com
2014-01-22 14:42 ` [PATCH 1/6] arm64: Add macros to manage processor debug state vijay.kilari at gmail.com
2014-01-22 17:31 ` Will Deacon
2014-01-23 4:46 ` Vijay Kilari
2014-01-23 9:57 ` Will Deacon
2014-01-22 14:42 ` [PATCH v7 2/6] arm64: KGDB: Add Basic KGDB support vijay.kilari at gmail.com
2014-01-22 14:42 ` [PATCH v7 3/6] arm64: KGDB: Add step debugging support vijay.kilari at gmail.com
2014-01-22 14:42 ` [PATCH v7 4/6] KGDB: make kgdb_breakpoint() as noinline vijay.kilari at gmail.com
2014-01-22 14:42 ` [PATCH v7 5/6] misc: debug: remove compilation warnings vijay.kilari at gmail.com
2014-01-22 16:11 ` Catalin Marinas [this message]
2014-01-22 14:42 ` [PATCH v7 6/6] arm64: KGDB: Add KGDB config vijay.kilari at gmail.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140122161152.GD8065@arm.com \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).