From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/6] arm64: Add macros to manage processor debug state
Date: Thu, 23 Jan 2014 09:57:42 +0000 [thread overview]
Message-ID: <20140123095741.GA5466@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <CALicx6sax=SHv2NryhY5QSBtyv-_wbCpPR5hFt9gngD96yP0oQ@mail.gmail.com>
On Thu, Jan 23, 2014 at 04:46:36AM +0000, Vijay Kilari wrote:
> On Wed, Jan 22, 2014 at 11:01 PM, Will Deacon <will.deacon@arm.com> wrote:
> >> diff --git a/arch/arm64/kernel/debug-monitors.c b/arch/arm64/kernel/debug-monitors.c
> >> index 23586bd..774ad04 100644
> >> --- a/arch/arm64/kernel/debug-monitors.c
> >> +++ b/arch/arm64/kernel/debug-monitors.c
> >> @@ -51,7 +51,7 @@ u8 debug_monitors_arch(void)
> >> static void mdscr_write(u32 mdscr)
> >> {
> >> unsigned long flags;
> >> - local_dbg_save(flags);
> >> + flags = local_dbg_save();
> >
> > Why are you changing the API? This is now pointlessly different to irqs.
>
> To be in line with arch_local_irq_save & arch_local_save_flags in irqflags.h,
> I moved this macros into functions and accordingly changed the caller.
> I could not find any code using this local_dbg_{save, restore} except
> from debug-monitors.c file
>
> If required, I can think of renaming local_dbg_{save,restore} as
> local_dbg_{save,restore}_flags
No, I'd rather local_dbg_{save, restore} were aligned with local_irq_{save,
restore} (as defined in include/linux/irqflags.h).
Will
next prev parent reply other threads:[~2014-01-23 9:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-22 14:42 [PATCH v7 0/6] arm64: KGDB Support vijay.kilari at gmail.com
2014-01-22 14:42 ` [PATCH 1/6] arm64: Add macros to manage processor debug state vijay.kilari at gmail.com
2014-01-22 17:31 ` Will Deacon
2014-01-23 4:46 ` Vijay Kilari
2014-01-23 9:57 ` Will Deacon [this message]
2014-01-22 14:42 ` [PATCH v7 2/6] arm64: KGDB: Add Basic KGDB support vijay.kilari at gmail.com
2014-01-22 14:42 ` [PATCH v7 3/6] arm64: KGDB: Add step debugging support vijay.kilari at gmail.com
2014-01-22 14:42 ` [PATCH v7 4/6] KGDB: make kgdb_breakpoint() as noinline vijay.kilari at gmail.com
2014-01-22 14:42 ` [PATCH v7 5/6] misc: debug: remove compilation warnings vijay.kilari at gmail.com
2014-01-22 16:11 ` Catalin Marinas
2014-01-22 14:42 ` [PATCH v7 6/6] arm64: KGDB: Add KGDB config vijay.kilari at gmail.com
-- strict thread matches above, loose matches on Subject: below --
2014-01-23 15:29 [PATCH 1/6] arm64: Add macros to manage processor debug state vijay.kilari at gmail.com
2014-01-24 16:39 ` Will Deacon
2014-01-28 11:33 ` Vijay Kilari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140123095741.GA5466@mudshark.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).