linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dts: edmqmx6: some fixes
@ 2014-01-22 19:39 Silvio F
  2014-01-22 19:39 ` [PATCH 1/2] ARM: dts: imx6: edmqmx6: fix wrong usbotg pingroup Silvio F
  2014-01-22 19:39 ` [PATCH 2/2] ARM: dts: imx6: edmqmx6: remove wrong gpio in usb_otg_vbus regulator Silvio F
  0 siblings, 2 replies; 6+ messages in thread
From: Silvio F @ 2014-01-22 19:39 UTC (permalink / raw)
  To: linux-arm-kernel

Hi,

please review and add this patches.

Thanks and Cheers,
       Silvio F.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/2] ARM: dts: imx6: edmqmx6: fix wrong usbotg pingroup
  2014-01-22 19:39 [PATCH] dts: edmqmx6: some fixes Silvio F
@ 2014-01-22 19:39 ` Silvio F
  2014-01-27  8:47   ` Sascha Hauer
  2014-01-28 12:06   ` Shawn Guo
  2014-01-22 19:39 ` [PATCH 2/2] ARM: dts: imx6: edmqmx6: remove wrong gpio in usb_otg_vbus regulator Silvio F
  1 sibling, 2 replies; 6+ messages in thread
From: Silvio F @ 2014-01-22 19:39 UTC (permalink / raw)
  To: linux-arm-kernel

Signed-off-by: Silvio F <silvio.fricke@gmail.com>
---
 arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts b/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts
index b8a1ff4..6706d1b 100644
--- a/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts
+++ b/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts
@@ -266,7 +266,7 @@
 		};
 
 		pinctrl_usbotg: usbotggrp {
-			fsl,pins = <MX6QDL_USBOTG_PINGRP1>;
+			fsl,pins = <MX6QDL_USBOTG_PINGRP2>;
 		};
 
 		pinctrl_usdhc3: usdhc3grp {
-- 
1.8.5.2

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] ARM: dts: imx6: edmqmx6: remove wrong gpio in usb_otg_vbus regulator
  2014-01-22 19:39 [PATCH] dts: edmqmx6: some fixes Silvio F
  2014-01-22 19:39 ` [PATCH 1/2] ARM: dts: imx6: edmqmx6: fix wrong usbotg pingroup Silvio F
@ 2014-01-22 19:39 ` Silvio F
  2014-01-27  8:51   ` Sascha Hauer
  1 sibling, 1 reply; 6+ messages in thread
From: Silvio F @ 2014-01-22 19:39 UTC (permalink / raw)
  To: linux-arm-kernel

Signed-off-by: Silvio F <silvio.fricke@gmail.com>
---
 arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts b/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts
index 6706d1b..de54e46 100644
--- a/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts
+++ b/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts
@@ -46,7 +46,6 @@
 			regulator-name = "usb_otg_vbus";
 			regulator-min-microvolt = <5000000>;
 			regulator-max-microvolt = <5000000>;
-			gpio = <&gpio7 12 0>;
 		};
 
 		reg_usb_host1: regulator at 2 {
-- 
1.8.5.2

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 1/2] ARM: dts: imx6: edmqmx6: fix wrong usbotg pingroup
  2014-01-22 19:39 ` [PATCH 1/2] ARM: dts: imx6: edmqmx6: fix wrong usbotg pingroup Silvio F
@ 2014-01-27  8:47   ` Sascha Hauer
  2014-01-28 12:06   ` Shawn Guo
  1 sibling, 0 replies; 6+ messages in thread
From: Sascha Hauer @ 2014-01-27  8:47 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Jan 22, 2014 at 08:39:26PM +0100, Silvio F wrote:
> Signed-off-by: Silvio F <silvio.fricke@gmail.com>

Verified this on the schematics, so:

Reviewed-by: Sascha Hauer <s.hauer@pengutronix.de>

> ---
>  arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts b/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts
> index b8a1ff4..6706d1b 100644
> --- a/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts
> +++ b/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts
> @@ -266,7 +266,7 @@
>  		};
>  
>  		pinctrl_usbotg: usbotggrp {
> -			fsl,pins = <MX6QDL_USBOTG_PINGRP1>;
> +			fsl,pins = <MX6QDL_USBOTG_PINGRP2>;
>  		};
>  
>  		pinctrl_usdhc3: usdhc3grp {
> -- 
> 1.8.5.2
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 2/2] ARM: dts: imx6: edmqmx6: remove wrong gpio in usb_otg_vbus regulator
  2014-01-22 19:39 ` [PATCH 2/2] ARM: dts: imx6: edmqmx6: remove wrong gpio in usb_otg_vbus regulator Silvio F
@ 2014-01-27  8:51   ` Sascha Hauer
  0 siblings, 0 replies; 6+ messages in thread
From: Sascha Hauer @ 2014-01-27  8:51 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Jan 22, 2014 at 08:39:27PM +0100, Silvio F wrote:
> Signed-off-by: Silvio F <silvio.fricke@gmail.com>
> ---
>  arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts b/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts
> index 6706d1b..de54e46 100644
> --- a/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts
> +++ b/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts
> @@ -46,7 +46,6 @@
>  			regulator-name = "usb_otg_vbus";
>  			regulator-min-microvolt = <5000000>;
>  			regulator-max-microvolt = <5000000>;
> -			gpio = <&gpio7 12 0>;

This gpio drives a switch between SoCs USB D+/D- lines and the external
connector, so using a regulator here is the wrong approach. The question
now is: What is the correct approach to make sure the switch is closed
when needed? How does it work now? Is the switch on by reset default?

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/2] ARM: dts: imx6: edmqmx6: fix wrong usbotg pingroup
  2014-01-22 19:39 ` [PATCH 1/2] ARM: dts: imx6: edmqmx6: fix wrong usbotg pingroup Silvio F
  2014-01-27  8:47   ` Sascha Hauer
@ 2014-01-28 12:06   ` Shawn Guo
  1 sibling, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2014-01-28 12:06 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Jan 22, 2014 at 08:39:26PM +0100, Silvio F wrote:
> Signed-off-by: Silvio F <silvio.fricke@gmail.com>
> ---
>  arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts b/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts
> index b8a1ff4..6706d1b 100644
> --- a/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts
> +++ b/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts
> @@ -266,7 +266,7 @@
>  		};
>  
>  		pinctrl_usbotg: usbotggrp {
> -			fsl,pins = <MX6QDL_USBOTG_PINGRP1>;
> +			fsl,pins = <MX6QDL_USBOTG_PINGRP2>;

The PINGRP header is gone now.  Please rebase it on branch below.

  git://git.linaro.org/people/shawn.guo/linux-2.6.git imx/dt

Shawn

>  		};
>  
>  		pinctrl_usdhc3: usdhc3grp {
> -- 
> 1.8.5.2
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2014-01-28 12:06 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-22 19:39 [PATCH] dts: edmqmx6: some fixes Silvio F
2014-01-22 19:39 ` [PATCH 1/2] ARM: dts: imx6: edmqmx6: fix wrong usbotg pingroup Silvio F
2014-01-27  8:47   ` Sascha Hauer
2014-01-28 12:06   ` Shawn Guo
2014-01-22 19:39 ` [PATCH 2/2] ARM: dts: imx6: edmqmx6: remove wrong gpio in usb_otg_vbus regulator Silvio F
2014-01-27  8:51   ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).