From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] ASoC: tda998x: adjust the audio hw parameters from EDID
Date: Mon, 27 Jan 2014 20:49:15 +0000 [thread overview]
Message-ID: <20140127204915.GC15937@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20140127204441.GZ11841@sirena.org.uk>
On Mon, Jan 27, 2014 at 08:44:41PM +0000, Mark Brown wrote:
> On Mon, Jan 27, 2014 at 09:48:54AM +0100, Jean-Francois Moine wrote:
>
> > + eld_ver = eld[0] >> 3;
> > + if (eld_ver != 2 && eld_ver != 31)
> > + return 0;
> > +
> > + mnl = eld[4] & 0x1f;
> > + if (mnl > 16)
> > + return 0;
> > +
> > + sad_count = eld[5] >> 4;
> > + sad = eld + 20 + mnl;
>
> Can this parsing code be factored out - it (or large parts of it) should
> be usable by other HDMI devices shouldn't it?
Yes, preferably as a generic ALSA helper rather than an ASoC helper -
I don't see any need for this to be ASoC specific (I have a pure ALSA
driver which has very similar code in it.)
--
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".
next prev parent reply other threads:[~2014-01-27 20:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-27 9:04 [PATCH 0/4] add a TDA998x CODEC Jean-Francois Moine
2014-01-26 18:02 ` [PATCH 1/4] drm/i2c: tda998x: add a function for dynamic audio input switch Jean-Francois Moine
2014-01-26 18:45 ` [PATCH 2/4] ASoC: tda998x: add a codec driver for TDA998x Jean-Francois Moine
2014-01-27 20:42 ` Mark Brown
2014-01-27 8:34 ` [PATCH 3/4] ASoC: tda998x: add DT documentation Jean-Francois Moine
2014-01-27 20:43 ` Mark Brown
2014-01-27 20:45 ` Russell King - ARM Linux
2014-01-27 20:56 ` Mark Brown
2014-01-27 8:48 ` [PATCH 4/4] ASoC: tda998x: adjust the audio hw parameters from EDID Jean-Francois Moine
2014-01-27 20:44 ` Mark Brown
2014-01-27 20:49 ` Russell King - ARM Linux [this message]
2014-01-27 20:54 ` Mark Brown
2014-01-28 9:23 ` [alsa-devel] " Takashi Iwai
2014-01-28 11:00 ` Mark Brown
2014-01-28 11:12 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140127204915.GC15937@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).