From: joshc@codeaurora.org (Josh Cartwright)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 4/6] spmi: pmic_arb: add support for interrupt handling
Date: Tue, 4 Feb 2014 14:57:14 -0600 [thread overview]
Message-ID: <20140204205714.GN20228@joshc.qualcomm.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1402042107311.24986@ionos.tec.linutronix.de>
On Tue, Feb 04, 2014 at 09:10:45PM +0100, Thomas Gleixner wrote:
> On Mon, 3 Feb 2014, Josh Cartwright wrote:
> > +static void qpnpint_irq_ack(struct irq_data *d)
> > +{
> > + struct spmi_pmic_arb_dev *pa = irq_data_get_irq_chip_data(d);
> > + u8 irq = d->hwirq >> 8;
> > + u8 apid = d->hwirq;
> > + unsigned long flags;
> > + u8 data;
> > +
> > + spin_lock_irqsave(&pa->lock, flags);
>
> This wants to be a raw_spinlock - think about RT!
Indeed. I'll change this in the next revision.
> Looks sane otherwise.
Great, thanks for taking a look!
Josh
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-02-04 20:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-03 23:05 [PATCH v5 0/6] Add support for the System Power Management Interface (SPMI) Josh Cartwright
2014-02-03 23:05 ` [PATCH v5 1/6] spmi: Linux driver framework for SPMI Josh Cartwright
2014-02-15 19:23 ` Greg Kroah-Hartman
2014-02-15 23:47 ` Felipe Balbi
2014-02-18 18:56 ` Josh Cartwright
2014-02-03 23:05 ` [PATCH v5 2/6] spmi: add generic SPMI controller binding documentation Josh Cartwright
2014-02-03 23:05 ` [PATCH v5 3/6] spmi: Add MSM PMIC Arbiter SPMI controller Josh Cartwright
2014-02-03 23:05 ` [PATCH v5 4/6] spmi: pmic_arb: add support for interrupt handling Josh Cartwright
2014-02-04 20:10 ` Thomas Gleixner
2014-02-04 20:57 ` Josh Cartwright [this message]
2014-02-03 23:05 ` [PATCH v5 5/6] spmi: document the PMIC arbiter SPMI bindings Josh Cartwright
2014-02-03 23:05 ` [PATCH v5 6/6] regmap: spmi: support base and extended register spaces Josh Cartwright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140204205714.GN20228@joshc.qualcomm.com \
--to=joshc@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).