From mboxrd@z Thu Jan 1 00:00:00 1970 From: mturquette@linaro.org (Mike Turquette) Date: Wed, 05 Feb 2014 06:08:02 -0800 Subject: [PATCH 0/4] clk: mvebu: fix clk init order In-Reply-To: <1390673950-4521-1-git-send-email-sebastian.hesselbarth@gmail.com> References: <1390673950-4521-1-git-send-email-sebastian.hesselbarth@gmail.com> Message-ID: <20140205140802.9977.19747@quantum> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Quoting Sebastian Hesselbarth (2014-01-25 10:19:06) > This patch set fixes clk init order that went upside-down with > v3.14. I haven't really investigated what caused this, but I assume > it is related with DT node reordering by addresses. > > Anyway, with v3.14 for MVEBU SoCs, the clock gating driver gets > registered before core clocks driver. Unfortunately, we cannot > return -EPROBE_DEFER in drivers initialized by clk_of_init. As the > init order for our drivers is always core clocks before clock gating, > we maintain init order ourselves by hooking CLK_OF_DECLARE to one > init function that will register core clocks before clock gating > driver. > > This patch is based on pre-v3.14-rc1 mainline and should go in as > fixes for it. As we now send MVEBU clk pull-requests to Mike directly, > I suggest Jason picks it up as a topic branch. Sebastian, These patches look OK to me. I'd rather take Gregory Clement's "respect the clock dependencies in of_clk_init" patch towards 3.15, so this fix will still be necessary for the current -rc's. Jason, will you be sending a PR? Thanks, Mike > > The patches have been boot tested on Dove and compile-tested only > for Kirkwood, Armada 370 and XP. > > Sebastian Hesselbarth (4): > clk: mvebu: armada-370: maintain clock init order > clk: mvebu: armada-xp: maintain clock init order > clk: mvebu: dove: maintain clock init order > clk: mvebu: kirkwood: maintain clock init order > > drivers/clk/mvebu/armada-370.c | 21 ++++++++++----------- > drivers/clk/mvebu/armada-xp.c | 20 +++++++++----------- > drivers/clk/mvebu/dove.c | 19 +++++++++---------- > drivers/clk/mvebu/kirkwood.c | 34 ++++++++++++++++------------------ > 4 files changed, 44 insertions(+), 50 deletions(-) > > --- > Cc: Mike Turquette > Cc: Jason Cooper > Cc: Andrew Lunn > Cc: Gregory Clement > Cc: Thomas Petazzoni > Cc: Ezequiel Garcia > Cc: linux-arm-kernel at lists.infradead.org > Cc: linux-kernel at vger.kernel.org > -- > 1.8.5.2 >