public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: pratyush.anand@st.com (Pratyush Anand)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V4 4/8] phy: st-miphy-40lp: Add skeleton driver
Date: Thu, 6 Feb 2014 11:55:54 +0530	[thread overview]
Message-ID: <20140206062554.GB2394@pratyush-vbox> (raw)
In-Reply-To: <52F32A58.1000904@ti.com>

On Thu, Feb 06, 2014 at 02:23:20PM +0800, Kishon Vijay Abraham I wrote:
> Hi,
> 
> On Thursday 06 February 2014 11:44 AM, Pratyush Anand wrote:
> > Hi Kishon,
> > 
> > On Thu, Feb 06, 2014 at 02:01:45PM +0800, Kishon Vijay Abraham I wrote:
> >> Hi,
> >>
> >> On Thursday 06 February 2014 10:14 AM, Pratyush Anand wrote:
> >>> ST miphy-40lp supports PCIe, SATA and Super Speed USB. This driver adds

[...]

> >>> +
> >>> +	phy_provider = devm_of_phy_provider_register(dev, st_miphy40lp_xlate);
> >>> +	if (IS_ERR(phy_provider)) {
> >>> +		dev_err(dev, "failed to register phy provider\n");
> >>> +		return PTR_ERR(phy_provider);
> >>> +	}
> >>
> >> phy_provider_register should be the last step in registering the PHY. Or your
> >> PHY call backs can be called before you create the PHY. Btw in your case you
> > 
> > But every one else like  phy-exynos-mipi-video or phy-omap-usb2 or any
> > other did it same way. First phy_provider_register and then
> > phy_create.
> 
> That's a bug which we figured out very late. Will get it fixed in this -rc cycle.

Ok..I ll correct in mine too. :)

Rgds
Pratyush
> 
> Thanks
> Kishon

  reply	other threads:[~2014-02-06  6:25 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-06  4:44 [PATCH V4 0/8]PCI:Add SPEAr13xx PCie support Pratyush Anand
2014-02-06  4:44 ` [PATCH V4 1/8] clk: SPEAr13xx: Fix pcie clock name Pratyush Anand
2014-02-06  4:44 ` [PATCH V4 2/8] SPEAr13xx: Fix static mapping table Pratyush Anand
2014-02-06  4:44 ` [PATCH V4 3/8] SPEAr13xx: defconfig: Update Pratyush Anand
2014-02-06  4:44 ` [PATCH V4 4/8] phy: st-miphy-40lp: Add skeleton driver Pratyush Anand
2014-02-06  6:01   ` Kishon Vijay Abraham I
2014-02-06  6:14     ` Pratyush Anand
2014-02-06  6:23       ` Kishon Vijay Abraham I
2014-02-06  6:25         ` Pratyush Anand [this message]
2014-02-06  4:44 ` [PATCH V4 5/8] SPEAr13xx: Fixup: Move SPEAr1340 SATA platform code to phy driver Pratyush Anand
2014-02-06  6:32   ` Kishon Vijay Abraham I
2014-02-06  7:00     ` Pratyush Anand
2014-02-06  8:01       ` Kishon Vijay Abraham I
2014-02-06  8:07         ` Pratyush Anand
2014-02-06  4:44 ` [PATCH V4 6/8] phy: st-miphy-40lp: Add SPEAr1310 and SPEAr1340 PCIe phy support Pratyush Anand
2014-02-06 15:37   ` Arnd Bergmann
2014-02-07  3:54     ` Pratyush Anand
2014-02-07  6:43       ` Pratyush Anand
2014-02-06 17:30 ` [PATCH V4 0/8]PCI:Add SPEAr13xx PCie support Pratyush Anand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140206062554.GB2394@pratyush-vbox \
    --to=pratyush.anand@st.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox