From: pratyush.anand@st.com (Pratyush Anand)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V4 6/8] phy: st-miphy-40lp: Add SPEAr1310 and SPEAr1340 PCIe phy support
Date: Fri, 7 Feb 2014 12:13:12 +0530 [thread overview]
Message-ID: <20140207064312.GC2414@pratyush-vbox> (raw)
In-Reply-To: <20140207035429.GB2414@pratyush-vbox>
Hi Arnd,
On Fri, Feb 07, 2014 at 11:54:30AM +0800, Pratyush ANAND wrote:
> Hi Arnd,
>
> On Thu, Feb 06, 2014 at 11:37:05PM +0800, Arnd Bergmann wrote:
> > On Thursday 06 February 2014, Pratyush Anand wrote:
> >
[...]
> > I think it's better to make this code table-driven. Rather than checking
> > 'of_device_is_compatible()', it's much easier to add a .data field to
> > the of_device_id array that describes the PHY. You can use .data to
> > point to a structure containing per-device function pointers or
> > (better) values and offsets to be used.
values and offset would be good as long as we do not need to write on
conditional read status. In our case its OK, as we do not need to
write conditionally. But, would it be a good idea to go that way?
Regards
Pratyush
>
> Sounds a better idea. will reduce code size a lot. Thanks.
>
> Regards
> Pratyush
>
> >
> > Arnd
next prev parent reply other threads:[~2014-02-07 6:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-06 4:44 [PATCH V4 0/8]PCI:Add SPEAr13xx PCie support Pratyush Anand
2014-02-06 4:44 ` [PATCH V4 1/8] clk: SPEAr13xx: Fix pcie clock name Pratyush Anand
2014-02-06 4:44 ` [PATCH V4 2/8] SPEAr13xx: Fix static mapping table Pratyush Anand
2014-02-06 4:44 ` [PATCH V4 3/8] SPEAr13xx: defconfig: Update Pratyush Anand
2014-02-06 4:44 ` [PATCH V4 4/8] phy: st-miphy-40lp: Add skeleton driver Pratyush Anand
2014-02-06 6:01 ` Kishon Vijay Abraham I
2014-02-06 6:14 ` Pratyush Anand
2014-02-06 6:23 ` Kishon Vijay Abraham I
2014-02-06 6:25 ` Pratyush Anand
2014-02-06 4:44 ` [PATCH V4 5/8] SPEAr13xx: Fixup: Move SPEAr1340 SATA platform code to phy driver Pratyush Anand
2014-02-06 6:32 ` Kishon Vijay Abraham I
2014-02-06 7:00 ` Pratyush Anand
2014-02-06 8:01 ` Kishon Vijay Abraham I
2014-02-06 8:07 ` Pratyush Anand
2014-02-06 4:44 ` [PATCH V4 6/8] phy: st-miphy-40lp: Add SPEAr1310 and SPEAr1340 PCIe phy support Pratyush Anand
2014-02-06 15:37 ` Arnd Bergmann
2014-02-07 3:54 ` Pratyush Anand
2014-02-07 6:43 ` Pratyush Anand [this message]
2014-02-06 17:30 ` [PATCH V4 0/8]PCI:Add SPEAr13xx PCie support Pratyush Anand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140207064312.GC2414@pratyush-vbox \
--to=pratyush.anand@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).