From mboxrd@z Thu Jan  1 00:00:00 1970
From: phdm@macq.eu (Philippe De Muyter)
Date: Mon, 10 Feb 2014 09:26:19 +0100
Subject: [PATCH] ARM: imx6q: support ptp and rmii clock from pad
In-Reply-To: <20140210060321.GG9628@S2101-09.ap.freescale.net>
References: <1391666018-12825-1-git-send-email-shawn.guo@linaro.org>
 <20140207104518.GA7085@frolo.macqel>
 <20140210060321.GG9628@S2101-09.ap.freescale.net>
Message-ID: <20140210082618.GA5555@frolo.macqel>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Mon, Feb 10, 2014 at 02:03:23PM +0800, Shawn Guo wrote:
> On Fri, Feb 07, 2014 at 11:45:18AM +0100, Philippe De Muyter wrote:
> > Thanks, Shawn
> > 
> > your patch works perfectly.  I can now use the same kernel on my sabresd
> > board (RGMII, enet_ref_clock generated by the imx6q) and my custom board
> > (RMII, clock generated by the PHY).
> 
> That's great.
> 
> > 
> > some comments. though :
> > 
> > the patch did not apply cleanly in clk-imx6q.c on v3.13
> 
> The patch targets v3.14-rc1, and if you need it for v3.13 you will need
> to back port it.
> 
> > 
> > don't forget to complete Documentation/devicetree/bindings/
> 
> It requires change on device tree sources but not bindings.  Which part
> of Documentation/devicetree/bindings/ do you think we need to update?

Would Documentation/devicetree/bindings/net/fsl-fec.txt (perhaps also
Documentation/devicetree/bindings/clock/imx6q-clock.txt) not be a good place
for that ?

Philippe

> 
> Shawn
> 
> > 
> > But, again, many thanks for the support
> > 
> > Philippe
> > 
> > 
> > On Thu, Feb 06, 2014 at 01:53:38PM +0800, Shawn Guo wrote:
> > > On imx6qdl, the ENET RMII and PTP clock can come from either internal
> > > ANATOP/CCM or external clock source through pad GPIO_16.  But in case
> > > of the external clock source, bit IOMUXC_GPR1[21] needs to be cleared.
> > > 
> > > The patch adds the support for systems that use an external clock source
> > > and distinguishes above two cases by checking if the PTP clock specified
> > > in device tree is the one coming from the internal ANATOP/CCM.
> > > 
> > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org>

-- 
Philippe De Muyter +32 2 6101532 Macq SA rue de l'Aeronef 2 B-1140 Bruxelles