[PATCH] staging: drm/imx: remove an unnecessary local variable

[PATCH] staging: drm/imx: remove an unnecessary local variable

[Russell King - ARM Linux]

On Mon, Feb 10, 2014 at 06:29:45PM +0800, Liu Ying wrote:
> This patch removes an unnecessary local variable defined
> in the function imx_drm_driver_unload() so as to fix the
> following build warning.
> 
> drivers/staging/imx-drm/imx-drm-core.c: \
> In function ?imx_drm_driver_unload?:
> drivers/staging/imx-drm/imx-drm-core.c:87:25: \
> warning: unused variable ?imxdrm? [-Wunused-variable]

Already-Naked-by: me.  This is required by later patches in the series
posted earlier.

-- 
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up.  Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".

[PATCH] staging: drm/imx: remove an unnecessary local variable

[Liu Ying]

This patch removes an unnecessary local variable defined
in the function imx_drm_driver_unload() so as to fix the
following build warning.

drivers/staging/imx-drm/imx-drm-core.c: \
In function ?imx_drm_driver_unload?:
drivers/staging/imx-drm/imx-drm-core.c:87:25: \
warning: unused variable ?imxdrm? [-Wunused-variable]

Signed-off-by: Liu Ying <Ying.Liu@freescale.com>
---
 drivers/staging/imx-drm/imx-drm-core.c |    2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/imx-drm/imx-drm-core.c b/drivers/staging/imx-drm/imx-drm-core.c
index 236ed66..573fe88 100644
--- a/drivers/staging/imx-drm/imx-drm-core.c
+++ b/drivers/staging/imx-drm/imx-drm-core.c
@@ -84,8 +84,6 @@ static void imx_drm_driver_lastclose(struct drm_device *drm)
 
 static int imx_drm_driver_unload(struct drm_device *drm)
 {
-	struct imx_drm_device *imxdrm = drm->dev_private;
-
 	imx_drm_device_put();
 
 	drm_vblank_cleanup(drm);
-- 
1.7.9.5

[PATCH] staging: drm/imx: remove an unnecessary local variable

[Liu Ying]

On 02/10/2014 06:29 PM, Russell King - ARM Linux wrote:
> On Mon, Feb 10, 2014 at 06:29:45PM +0800, Liu Ying wrote:
>> This patch removes an unnecessary local variable defined
>> in the function imx_drm_driver_unload() so as to fix the
>> following build warning.
>>
>> drivers/staging/imx-drm/imx-drm-core.c: \
>> In function ?imx_drm_driver_unload?:
>> drivers/staging/imx-drm/imx-drm-core.c:87:25: \
>> warning: unused variable ?imxdrm? [-Wunused-variable]
> 
> Already-Naked-by: me.  This is required by later patches in the series
> posted earlier.
> 

Sorry. Did you mean that you have already got a fix for this?

[PATCH] staging: drm/imx: remove an unnecessary local variable

[Russell King - ARM Linux]

On Mon, Feb 10, 2014 at 06:42:57PM +0800, Liu Ying wrote:
> On 02/10/2014 06:29 PM, Russell King - ARM Linux wrote:
> > On Mon, Feb 10, 2014 at 06:29:45PM +0800, Liu Ying wrote:
> >> This patch removes an unnecessary local variable defined
> >> in the function imx_drm_driver_unload() so as to fix the
> >> following build warning.
> >>
> >> drivers/staging/imx-drm/imx-drm-core.c: \
> >> In function ?imx_drm_driver_unload?:
> >> drivers/staging/imx-drm/imx-drm-core.c:87:25: \
> >> warning: unused variable ?imxdrm? [-Wunused-variable]
> > 
> > Already-Naked-by: me.  This is required by later patches in the series
> > posted earlier.
> > 
> 
> Sorry. Did you mean that you have already got a fix for this?

No, I mean patches which come after the three which Greg has recently
merged - one of which removes users of the above variable - reintroduce
users of this variable, so deleting the variable will break those patches.
It was also pointless to remove it and then bring it back in the series.

-- 
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up.  Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".