From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH] ARM: Add imprecise abort enable/disable macro
Date: Mon, 10 Feb 2014 15:24:52 +0000 [thread overview]
Message-ID: <20140210152452.GA26684@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20140210151247.GD2794@e103592.cambridge.arm.com>
On Mon, Feb 10, 2014 at 03:12:47PM +0000, Dave Martin wrote:
> Firstly, blindly adding 4 to PC is obviouly not right, partly because we
> might be running an unrelated thread by the time the abort fires, and
> also because the affected instruction might not be 4 bytes in size in a
> Thumb kernel.
Exactly. We ended up on some platforms having special accessors for PCI
where we included a number of 'mov r0, r0' instructions after the accessor
so we could properly cope with them - but this required knowledge that
we were going to only receive an imprecise abort from these accessors
and only for a few cycles after the instruction.
However, that's not true with modern architectures. The point they're
received will _not_ be the load/store which resulted in the abort, and
in the case of a write, they could be many hundreds of cycles later,
especially if the write has been buffered.
So adding four to the PC is definitely a very /bad/ thing to do.
--
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".
next prev parent reply other threads:[~2014-02-10 15:24 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 16:19 [RFC PATCH] ARM: Enable imprecise external aborts earlier Fabrice GASNIER
2014-02-07 16:19 ` [RFC PATCH] ARM: Add imprecise abort enable/disable macro Fabrice GASNIER
2014-02-07 17:09 ` Will Deacon
2014-02-10 8:50 ` Fabrice Gasnier
2014-02-10 9:00 ` Ben Dooks
2014-02-10 13:32 ` Fabrice Gasnier
2014-02-10 11:17 ` Will Deacon
2014-02-10 13:54 ` Fabrice Gasnier
2014-02-10 13:56 ` Russell King - ARM Linux
2014-02-10 14:12 ` Will Deacon
2014-02-10 14:42 ` Dave Martin
2014-02-10 15:19 ` Russell King - ARM Linux
2014-02-10 16:28 ` Dave Martin
2014-02-10 16:37 ` Russell King - ARM Linux
2014-02-10 17:28 ` Dave Martin
2014-02-10 13:58 ` Russell King - ARM Linux
2014-02-10 14:16 ` Dave Martin
2014-02-10 14:44 ` Fabrice Gasnier
2014-02-10 15:12 ` Dave Martin
2014-02-10 15:24 ` Russell King - ARM Linux [this message]
2014-02-10 16:36 ` Fabrice Gasnier
2014-02-10 14:54 ` Ben Dooks
2014-02-10 15:21 ` Dave Martin
2014-02-10 16:38 ` Ben Dooks
2014-02-11 15:38 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140210152452.GA26684@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).