From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 07/11] ARM: mvebu: add initial support for the Armada 380/385 SOCs
Date: Mon, 10 Feb 2014 18:44:04 +0100 [thread overview]
Message-ID: <20140210174404.GC9995@lunn.ch> (raw)
In-Reply-To: <1392053002-19831-8-git-send-email-thomas.petazzoni@free-electrons.com>
Hi Thomas
> +config MACH_ARMADA_380
Should this maybe be MACH_ARMADA_38X. You have PINCTRL_ARMADA_38X, so
it seems a bit inconsistent.
> +
> +static void __init armada_380_timer_and_clk_init(void)
> +{
> + of_clk_init(NULL);
> + clocksource_of_init();
> + BUG_ON(mvebu_mbus_dt_init());
> + l2x0_of_init(0, ~0UL);
> +}
> +
> +static const char * const armada_380_dt_compat[] = {
> + "marvell,armada380",
> + "marvell,armada385",
> + NULL,
> +};
> +
> +DT_MACHINE_START(ARMADA_XP_DT, "Marvell Armada 380/385 (Device Tree)")
> + .init_time = armada_380_timer_and_clk_init,
> + .restart = mvebu_restart,
> + .dt_compat = armada_380_dt_compat,
> +MACHINE_END
This looks very similar to the 375 code. Could they be combined?
Andrew
next prev parent reply other threads:[~2014-02-10 17:44 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 17:23 [PATCH 00/11] Core support for Marvell Armada 375 and 38x Thomas Petazzoni
2014-02-10 17:23 ` [PATCH 01/11] ARM: mvebu: add Armada 375 support to the system-controller driver Thomas Petazzoni
2014-02-10 17:23 ` [PATCH 02/11] ARM: mvebu: add initial support for the Armada 375 SOCs Thomas Petazzoni
2014-02-10 17:23 ` [PATCH 03/11] ARM: mvebu: add workaround for data abort issue on Armada 375 Thomas Petazzoni
2014-02-10 17:23 ` [PATCH 04/11] ARM: mvebu: add Device Tree description of the Armada 375 SoC Thomas Petazzoni
2014-02-10 17:35 ` Jason Cooper
2014-02-10 17:37 ` Gregory CLEMENT
2014-02-10 17:23 ` [PATCH 05/11] ARM: mvebu: add Device Tree for the Armada 375 DB board Thomas Petazzoni
2014-02-10 17:37 ` Andrew Lunn
2014-02-10 17:47 ` Thomas Petazzoni
2014-02-10 17:23 ` [PATCH 06/11] ARM: mvebu: add Armada 380/385 support to the system-controller driver Thomas Petazzoni
2014-02-10 17:39 ` Jason Cooper
2014-02-10 17:47 ` Thomas Petazzoni
2014-02-10 18:48 ` Jason Cooper
2014-02-10 19:03 ` Thomas Petazzoni
2014-02-11 14:22 ` Grant Likely
2014-02-11 15:24 ` Thomas Petazzoni
2014-02-11 15:30 ` Jason Cooper
2014-02-11 15:50 ` Gregory CLEMENT
2014-02-10 17:23 ` [PATCH 07/11] ARM: mvebu: add initial support for the Armada 380/385 SOCs Thomas Petazzoni
2014-02-10 17:44 ` Andrew Lunn [this message]
2014-02-10 17:55 ` Thomas Petazzoni
2014-02-10 17:23 ` [PATCH 08/11] ARM: mvebu: add Device Tree description of the Armada 380/385 SoCs Thomas Petazzoni
2014-02-10 17:23 ` [PATCH 09/11] ARM: mvebu: add Device Tree for the Armada 385 DB board Thomas Petazzoni
2014-02-10 17:23 ` [PATCH 10/11] ARM: mvebu: update defconfigs for Armada 375 and 38x Thomas Petazzoni
2014-02-10 17:23 ` [PATCH 11/11] Documentation: arm: update Marvell documentation about Armada 375/38x Thomas Petazzoni
2014-02-10 17:47 ` [PATCH 00/11] Core support for Marvell Armada 375 and 38x Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140210174404.GC9995@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).