From: Dave.Martin@arm.com (Dave Martin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: asm: rename logical shift macros push pull into lspush lspull
Date: Tue, 11 Feb 2014 15:59:28 +0000 [thread overview]
Message-ID: <20140211155928.GD3035@e103592.cambridge.arm.com> (raw)
In-Reply-To: <20140211155437.GC3035@e103592.cambridge.arm.com>
On Tue, Feb 11, 2014 at 03:54:37PM +0000, Dave Martin wrote:
> On Mon, Feb 10, 2014 at 04:30:01PM -0500, Nicolas Pitre wrote:
> > On Mon, 10 Feb 2014, Victor Kamensky wrote:
> >
> > > Renames logical shift macros, 'push' and 'pull', defined in
> > > arch/arm/include/asm/assembler.h, into 'lspush' and 'lspull'.
> >
> > I don't have any fundamental objection to the idea, except maybe for the
> > actual names. I just can't come up with anything better though.
>
> For consistency with the get_byte_ stuff, how about:
>
> push -> towards_byte_0
> pull -> from_byte_0
>
> That may make the purpose a little clearer, too.
>
> (Assuming I've got them the right way around...)
(Actually, I did get it the wrong way round by the look of it.
But you get the general idea.)
Cheers
---Dave
next prev parent reply other threads:[~2014-02-11 15:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 20:19 [PATCH v2] ARM: asm: rename logical shift macros push pull into lspush lspull Victor Kamensky
2014-02-10 20:19 ` Victor Kamensky
2014-02-10 21:30 ` Nicolas Pitre
2014-02-11 15:54 ` Dave Martin
2014-02-11 15:59 ` Dave Martin [this message]
2014-02-11 17:09 ` Nicolas Pitre
2014-02-11 17:37 ` Dave Martin
2014-02-11 17:58 ` Nicolas Pitre
2014-02-11 19:36 ` Victor Kamensky
2014-02-11 19:52 ` Victor Kamensky
2014-02-11 20:31 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140211155928.GD3035@e103592.cambridge.arm.com \
--to=dave.martin@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox