From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: fix psci power state pack
Date: Wed, 12 Feb 2014 10:19:46 +0000 [thread overview]
Message-ID: <20140212101946.GD13441@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <1392196958-2507-1-git-send-email-pgaikwad@nvidia.com>
On Wed, Feb 12, 2014 at 09:22:38AM +0000, Prashant Gaikwad wrote:
> Values has to be shifted right to create pack.
NAK. This doesn't make any sense to me.
> Signed-off-by: Prashant Gaikwad <pgaikwad@nvidia.com>
> ---
> arch/arm64/kernel/psci.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/kernel/psci.c b/arch/arm64/kernel/psci.c
> index 4f97db3..6e8f1df 100644
> --- a/arch/arm64/kernel/psci.c
> +++ b/arch/arm64/kernel/psci.c
> @@ -87,11 +87,11 @@ static int psci_to_linux_errno(int errno)
> static u32 psci_power_state_pack(struct psci_power_state state)
> {
> return ((state.id & PSCI_POWER_STATE_ID_MASK)
> - << PSCI_POWER_STATE_ID_SHIFT) |
> + >> PSCI_POWER_STATE_ID_SHIFT) |
> ((state.type & PSCI_POWER_STATE_TYPE_MASK)
> - << PSCI_POWER_STATE_TYPE_SHIFT) |
> + >> PSCI_POWER_STATE_TYPE_SHIFT) |
So for the type field, this becomes:
(state.type & 0x1) >> 16
Are you sure?
Will
next prev parent reply other threads:[~2014-02-12 10:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-12 9:22 [PATCH] arm64: fix psci power state pack Prashant Gaikwad
2014-02-12 10:19 ` Will Deacon [this message]
2014-02-12 10:42 ` Prashant Gaikwad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140212101946.GD13441@mudshark.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox