From mboxrd@z Thu Jan 1 00:00:00 1970 From: daniel@ffwll.ch (Daniel Vetter) Date: Wed, 12 Feb 2014 19:29:01 +0100 Subject: [BUG] Circular locking dependency - DRM/CMA/MM/hotplug/... In-Reply-To: <20140212163317.GQ26684@n2100.arm.linux.org.uk> References: <20140211183543.GK26684@n2100.arm.linux.org.uk> <52FB9602.1000805@samsung.com> <20140212163317.GQ26684@n2100.arm.linux.org.uk> Message-ID: <20140212182901.GX17001@phenom.ffwll.local> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Feb 12, 2014 at 04:33:17PM +0000, Russell King - ARM Linux wrote: > On Wed, Feb 12, 2014 at 04:40:50PM +0100, Marek Szyprowski wrote: > >> -> #3 (console_lock){+.+.+.}: > >> [] __lock_acquire+0x151c/0x1ca0 > >> [] lock_acquire+0xa0/0x130 > >> [] console_lock+0x60/0x74 > >> [] console_cpu_notify+0x28/0x34 > >> [] notifier_call_chain+0x4c/0x8c > >> [] __raw_notifier_call_chain+0x1c/0x24 > >> [] __cpu_notify+0x34/0x50 > >> [] cpu_notify_nofail+0x18/0x24 > >> [] _cpu_down+0x100/0x244 > >> [] cpu_down+0x30/0x44 > >> [] cpu_subsys_offline+0x14/0x18 > >> [] device_offline+0x94/0xbc > >> [] online_store+0x4c/0x74 > >> [] dev_attr_store+0x20/0x2c > >> [] sysfs_kf_write+0x54/0x58 > >> [] kernfs_fop_write+0xc4/0x160 > >> [] vfs_write+0xbc/0x184 > >> [] SyS_write+0x48/0x70 > >> [] ret_fast_syscall+0x0/0x48 > > cpu_down() takes cpu_hotplug.lock, so here we have: > > cpu_hotplug.lock > console_lock The patche I've linked in my other mail will break the chain here, so should solve this. And apparently with cpu hotplug we can hit this, too. And having banged my head against the console_lock wall I think doing a trylock here is generally the sanest option. So imo we can just blame console_lock, not need to either beat up v4l, drm, cma or anyone else really ;-) Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch