From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] ARM: sunxi: dt: Convert to the new i2c compatibles
Date: Thu, 13 Feb 2014 09:26:30 +0100 [thread overview]
Message-ID: <20140213082630.GA3119@katana> (raw)
In-Reply-To: <1391680285-16668-3-git-send-email-maxime.ripard@free-electrons.com>
Why is the devicetree list not on CC? (Added now)
On Thu, Feb 06, 2014 at 10:51:25AM +0100, Maxime Ripard wrote:
> Switch the device tree to the new compatibles introduced in the i2c drivers
> to have a common pattern accross all Allwinner SoCs.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
> arch/arm/boot/dts/sun4i-a10.dtsi | 6 +++---
> arch/arm/boot/dts/sun5i-a10s.dtsi | 6 +++---
> arch/arm/boot/dts/sun5i-a13.dtsi | 6 +++---
> arch/arm/boot/dts/sun7i-a20.dtsi | 10 +++++-----
> 4 files changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi
> index 28273f9..ac65c8a 100644
> --- a/arch/arm/boot/dts/sun4i-a10.dtsi
> +++ b/arch/arm/boot/dts/sun4i-a10.dtsi
> @@ -518,7 +518,7 @@
> };
>
> i2c0: i2c at 01c2ac00 {
> - compatible = "allwinner,sun4i-i2c";
> + compatible = "allwinner,sun4i-a10-i2c";
Can't we have:
compatible = "allwinner,sun4i-a10-i2c", "allwinner,sun4i-i2c";
? And keep the old "allwinner,sun4i-i2c" and extend it with a SoC
specific a10 compatible entry when a distinction is needed?
> diff --git a/arch/arm/boot/dts/sun5i-a13.dtsi b/arch/arm/boot/dts/sun5i-a13.dtsi
> index 6de40b6..537072c 100644
> --- a/arch/arm/boot/dts/sun5i-a13.dtsi
> +++ b/arch/arm/boot/dts/sun5i-a13.dtsi
> @@ -377,7 +377,7 @@
> };
>
> i2c0: i2c at 01c2ac00 {
> - compatible = "allwinner,sun4i-i2c";
> + compatible = "allwinner,sun4i-a10-i2c";
For non-a10, That should be at least
compatible = "allwinner,sun4i-a13-i2c", "allwinner,sun4i-a10-i2c";
or
compatible = "allwinner,sun4i-a13-i2c", "allwinner,sun4i-i2c";
depending on the outcome above.
Or is my knowledge outdated already?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140213/a0ffedbe/attachment.sig>
next prev parent reply other threads:[~2014-02-13 8:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-06 9:51 [PATCH v2 0/2] i2c: sunxi: Change compatibles pattern Maxime Ripard
2014-02-06 9:51 ` [PATCH v2 1/2] i2c: sunxi: Change i2c compatibles Maxime Ripard
2014-02-06 9:51 ` [PATCH v2 2/2] ARM: sunxi: dt: Convert to the new " Maxime Ripard
2014-02-13 8:26 ` Wolfram Sang [this message]
2014-02-13 22:52 ` Maxime Ripard
2014-02-14 7:44 ` Wolfram Sang
2014-02-14 20:36 ` Maxime Ripard
2014-02-13 8:19 ` [PATCH v2 0/2] i2c: sunxi: Change compatibles pattern Wolfram Sang
2014-02-13 22:37 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140213082630.GA3119@katana \
--to=wsa@the-dreams.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).