From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 03/10] ARM: mvebu: add workaround for data abort issue on Armada 375
Date: Thu, 13 Feb 2014 11:56:14 +0100 [thread overview]
Message-ID: <20140213115614.71e95251@skate> (raw)
In-Reply-To: <2289743.0TLVompA6m@wuerfel>
Dear Arnd Bergmann,
On Wed, 12 Feb 2014 14:10:35 +0100, Arnd Bergmann wrote:
> On Wednesday 12 February 2014 11:23:32 Thomas Petazzoni wrote:
> > +/*
> > + * Early versions of Armada 375 SoC have a bug where the BootROM
> > + * leaves an external data abort pending. The kernel is hit by this
> > + * data abort as soon as it enters userspace, because it unmasks the
> > + * data aborts at this moment. We register a custom abort handler
> > + * below to ignore the first data abort to work around this problem.
> > + */
> > +static int armada_375_external_abort_wa(unsigned long addr, unsigned int fsr,
> > + struct pt_regs *regs)
> > +{
> > + static int ignore_first;
> > +
> > + if (!ignore_first) {
> > + ignore_first = 1;
> > + return 0;
> > + }
> > +
> > + return 1;
> > +}
>
> I think this should try to match the fsr and addr field if possible and
> only ignore the one external abort you expect.
I've added a check on fsr. Checking addr is not possible, because the
address changes from one boot to another. I must say I don't really
know the details of the BootROM code that leaves this data abort
pending, but it looks like the address that triggers the data abort is
not always the same.
Thanks for your review!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-02-13 10:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-12 10:23 [PATCH v2 00/10] Core support for Marvell Armada 375 and 38x Thomas Petazzoni
2014-02-12 10:23 ` [PATCH v2 01/10] ARM: mvebu: add Armada 375 support to the system-controller driver Thomas Petazzoni
2014-02-12 10:23 ` [PATCH v2 02/10] ARM: mvebu: add initial support for the Armada 375 SOCs Thomas Petazzoni
2014-02-12 13:08 ` Arnd Bergmann
2014-02-13 10:55 ` Thomas Petazzoni
2014-02-12 10:23 ` [PATCH v2 03/10] ARM: mvebu: add workaround for data abort issue on Armada 375 Thomas Petazzoni
2014-02-12 13:10 ` Arnd Bergmann
2014-02-13 10:56 ` Thomas Petazzoni [this message]
2014-02-12 10:23 ` [PATCH v2 04/10] ARM: mvebu: add Device Tree description of the Armada 375 SoC Thomas Petazzoni
2014-02-12 10:23 ` [PATCH v2 05/10] ARM: mvebu: add Device Tree for the Armada 375 DB board Thomas Petazzoni
2014-02-12 13:12 ` Arnd Bergmann
2014-02-13 10:56 ` Thomas Petazzoni
2014-02-12 10:23 ` [PATCH v2 06/10] ARM: mvebu: add initial support for the Armada 380/385 SOCs Thomas Petazzoni
2014-02-12 10:23 ` [PATCH v2 07/10] ARM: mvebu: add Device Tree description of the Armada 380/385 SoCs Thomas Petazzoni
2014-02-12 10:23 ` [PATCH v2 08/10] ARM: mvebu: add Device Tree for the Armada 385 DB board Thomas Petazzoni
2014-02-12 10:23 ` [PATCH v2 09/10] ARM: mvebu: update defconfigs for Armada 375 and 38x Thomas Petazzoni
2014-02-12 10:23 ` [PATCH v2 10/10] Documentation: arm: update Marvell documentation about Armada 375/38x Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140213115614.71e95251@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox