From mboxrd@z Thu Jan  1 00:00:00 1970
From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
Date: Thu, 13 Feb 2014 11:56:25 +0100
Subject: [PATCH v2 05/10] ARM: mvebu: add Device Tree for the Armada 375
 DB board
In-Reply-To: <2335694.A7tsOBXSlH@wuerfel>
References: <1392200619-3141-1-git-send-email-thomas.petazzoni@free-electrons.com>
 <1392200619-3141-6-git-send-email-thomas.petazzoni@free-electrons.com>
 <2335694.A7tsOBXSlH@wuerfel>
Message-ID: <20140213115625.15dda6d9@skate>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

Dear Arnd Bergmann,

On Wed, 12 Feb 2014 14:12:27 +0100, Arnd Bergmann wrote:
> On Wednesday 12 February 2014 11:23:34 Thomas Petazzoni wrote:
> > +                       i2c0: i2c at 11000 {
> > +                               status = "okay";
> > +                               clock-frequency = <100000>;
> > +                               pinctrl-0 = <&i2c0_pins>;
> > +                               pinctrl-names = "default";
> > +                       };
> > +
> > +                       i2c1: i2c at 11100 {
> > +                               status = "okay";
> > +                               clock-frequency = <100000>;
> > +                               pinctrl-0 = <&i2c1_pins>;
> > +                               pinctrl-names = "default";
> > +                       };
> 
> I think you should either use the label to reference the node here,
> or omit it in the board.dts file. There is no point in defining
> multiple identical labels.

Indeed, good point. Will be fixed in v3.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com