From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: kernel: improve error message when LPAE config doesn't match CPU
Date: Tue, 18 Feb 2014 14:31:27 +0000 [thread overview]
Message-ID: <20140218143126.GI4178@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <1392729618-25094-1-git-send-email-thomas.petazzoni@free-electrons.com>
On Tue, Feb 18, 2014 at 01:20:18PM +0000, Thomas Petazzoni wrote:
> Currently, when the kernel is configured with LPAE support, but the
> CPU doesn't support it, the error message is fairly cryptic:
>
> Error: unrecognized/unsupported processor variant (0x561f5811).
>
> This messages is normally shown when there is an issue when comparing
> the processor ID (CP15 0, c0, c0) with the values/masks described in
> proc-v7.S. However, the same message is displayed when LPAE support is
> enabled in the kernel configuration, but not available in the CPU,
> after looking at ID_MMFR0 (CP15 0, c0, c1, 4). Having the same error
> message is highly misleading.
>
> This commit improves this by showing a different error message when
> this situation occurs:
>
> Error: Kernel with LPAE support, but CPU does not support LPAE.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Looks sensible enough to me:
Acked-by: Will Deacon <will.deacon@arm.com>
Will
next prev parent reply other threads:[~2014-02-18 14:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-18 13:20 [PATCH] ARM: kernel: improve error message when LPAE config doesn't match CPU Thomas Petazzoni
2014-02-18 14:31 ` Will Deacon [this message]
2014-02-18 15:35 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140218143126.GI4178@mudshark.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).