linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: steve.capper@linaro.org (Steve Capper)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2] arm: mm: Remove hugetlb warning from Coherent DMA allocator
Date: Tue, 18 Feb 2014 15:59:39 +0000	[thread overview]
Message-ID: <20140218155938.GA28940@linaro.org> (raw)
In-Reply-To: <20140218154930.GG21483@n2100.arm.linux.org.uk>

On Tue, Feb 18, 2014 at 03:49:30PM +0000, Russell King - ARM Linux wrote:
> On Tue, Feb 18, 2014 at 03:45:51PM +0000, Steve Capper wrote:
> > On Thu, Jan 16, 2014 at 10:07:43AM +0000, Steve Capper wrote:
> > > The Coherant DMA allocator allocates pages of high order then splits
> > > them up into smaller pages.
> > > 
> > > This splitting logic would run into problems if the allocator was
> > > given compound pages. Thus the Coherant DMA allocator was originally
> > > incompatible with compound pages existing and, by extension, huge
> > > pages. A compile #error was put in place whenever huge pages were
> > > enabled.
> > > 
> > > Compatibility with compound pages has since been introduced by the
> > > following commit (which merely excludes GFP_COMP pages from being
> > > requested by the coherant DMA allocator):
> > >   ea2e705 ARM: 7172/1: dma: Drop GFP_COMP for DMA memory allocations
> > > 
> > > When huge page support was introduced to ARM, the compile #error in
> > > dma-mapping.c was replaced by a #warning when it should have been
> > > removed instead.
> > > 
> > > This patch removes the compile #warning in dma-mapping.c when huge
> > > pages are enabled.
> > > 
> > > Signed-off-by: Steve Capper <steve.capper@linaro.org>
> > > ---
> > > Changed in V2: commit message completely re-written to give a better
> > > justification.
> > > ---
> > >  arch/arm/mm/dma-mapping.c | 3 ---
> > >  1 file changed, 3 deletions(-)
> > 
> > Would anyone object to this going into Russell's patch system?
> 
> It's been a month, no one's objected, so please put it in the patch
> system anyway, thanks.
> 

Cheers, that's in as 7979/1.

-- 
Steve

      reply	other threads:[~2014-02-18 15:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-16 10:07 [PATCH V2] arm: mm: Remove hugetlb warning from Coherent DMA allocator Steve Capper
2014-02-18 15:45 ` Steve Capper
2014-02-18 15:49   ` Russell King - ARM Linux
2014-02-18 15:59     ` Steve Capper [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140218155938.GA28940@linaro.org \
    --to=steve.capper@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).