From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 1/8] ARM: at91: Add at91sam9rl DT SoC support
Date: Thu, 20 Feb 2014 09:09:55 +0100 [thread overview]
Message-ID: <20140220080955.GA3142@lukather> (raw)
In-Reply-To: <20140219170020.GA25079@e106331-lin.cambridge.arm.com>
Hi Mark,
On Wed, Feb 19, 2014 at 05:00:20PM +0000, Mark Rutland wrote:
> > + adc0: adc at fffd0000 {
> > + compatible = "atmel,at91sam9260-adc";
> > + reg = <0xfffd0000 0x100>;
> > + interrupts = <20 IRQ_TYPE_LEVEL_HIGH 0>;
> > + atmel,adc-use-external-triggers;
> > + atmel,adc-channels-used = <0xf>;
> > + atmel,adc-vref = <3300>;
> > + atmel,adc-num-channels = <4>;
> > + atmel,adc-startup-time = <15>;
> > + atmel,adc-channel-base = <0x30>;
> > + atmel,adc-drdy-mask = <0x10000>;
> > + atmel,adc-status-register = <0x1c>;
> > + atmel,adc-trigger-register = <0x04>;
> > + atmel,adc-res = <8 10>;
> > + atmel,adc-res-names = "lowres", "highres";
> > + atmel,adc-use-res = "highres";
> > +
> > + trigger at 0 {
> > + trigger-name = "timer-counter-0";
> > + trigger-value = <0x1>;
> > + };
>
> A unit-address should go with a reg value. Either this needs a reg and
> the parent node needs #address-cells and #size-cells, or the
> unit-address should go, and the names made unique through other means.
What do you suggest to make the name unique then?
The ePAPR is pretty clear that the above is the way to go, so I'm
unclear on what you have in mind here.
Plus, I haven't seen anywhere that reg was actually mandatory.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140220/9ed94870/attachment.sig>
next prev parent reply other threads:[~2014-02-20 8:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 15:32 [PATCHv2 0/8] Device tree support for the at91sam9rlek Alexandre Belloni
2014-02-19 15:32 ` [PATCHv2 1/8] ARM: at91: Add at91sam9rl DT SoC support Alexandre Belloni
2014-02-19 16:01 ` Boris BREZILLON
2014-02-19 16:19 ` Jean-Jacques Hiblot
2014-02-19 17:10 ` Boris BREZILLON
2014-02-20 8:14 ` Nicolas Ferre
2014-02-19 17:00 ` Mark Rutland
2014-02-19 17:28 ` Boris BREZILLON
2014-02-19 17:31 ` Alexandre Belloni
2014-02-19 17:54 ` Mark Rutland
2014-02-20 8:59 ` Boris BREZILLON
2014-02-20 9:12 ` Nicolas Ferre
2014-02-21 20:04 ` Alexandre Belloni
2014-02-20 8:09 ` Maxime Ripard [this message]
2014-02-19 15:32 ` [PATCHv2 2/8] ARM: at91/defconfig: Add the sam9rl to the list of DT-enabled SOCs Alexandre Belloni
2014-02-19 15:32 ` [PATCHv2 3/8] ARM: at91: dt: sam9rl: Device Tree for the at91sam9rlek Alexandre Belloni
2014-02-19 17:02 ` Mark Rutland
2014-02-19 15:32 ` [PATCHv2 4/8] ARM: at91: prepare sam9 dt boards transition to common clk Alexandre Belloni
2014-02-19 15:32 ` [PATCHv2 5/8] ARM: at91: prepare common clk transition for sam9rl SoCs Alexandre Belloni
2014-02-19 15:32 ` [PATCHv2 6/8] ARM: at91/dt: define at91sam9rl clocks Alexandre Belloni
2014-02-19 15:32 ` [PATCHv2 7/8] ARM: at91/dt: define main clk frequency of at91sam9rlek Alexandre Belloni
2014-02-19 15:32 ` [PATCHv2 8/8] ARM: at91: switch sam9rl to common clock framework Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140220080955.GA3142@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).