From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v10 01/15] usb: doc: phy-mxs: Add more compatible strings
Date: Fri, 21 Feb 2014 09:13:46 +0000 [thread overview]
Message-ID: <20140221091345.GA7541@e106331-lin.cambridge.arm.com> (raw)
In-Reply-To: <1392873284-9386-2-git-send-email-peter.chen@freescale.com>
On Thu, Feb 20, 2014 at 05:14:30AM +0000, Peter Chen wrote:
> Add "fsl,imx6q-usbphy" for imx6dq and imx6dl, add
> "fsl,imx6sl-usbphy" for imx6sl.
>
> Signed-off-by: Peter Chen <peter.chen@freescale.com>
> ---
> Documentation/devicetree/bindings/usb/mxs-phy.txt | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/mxs-phy.txt b/Documentation/devicetree/bindings/usb/mxs-phy.txt
> index 5835b27..b43d4c9e 100644
> --- a/Documentation/devicetree/bindings/usb/mxs-phy.txt
> +++ b/Documentation/devicetree/bindings/usb/mxs-phy.txt
> @@ -1,7 +1,8 @@
> * Freescale MXS USB Phy Device
>
> Required properties:
> -- compatible: Should be "fsl,imx23-usbphy"
> +- compatible: "fsl,imx23-usbphy" for imx23 and imx28, "fsl,imx6q-usbphy"
> + for imx6dq and imx6dl, "fsl,imx6sl-usbphy" for imx6sl
Minor nit, but could we restructure this as something like the
following, with each string on a new line:
- compatible: should contain:
* "fsl,imx23-usbphy" for imx23 and imx28
* "fsl,imx6q-usbphy" for imx6dq and imx6dl
* "fsl,imx6sl-usbphy" for imx6sl
It makes it a bit easier to read.
I see the existing "fsl,imx23-usbphy" is used as a fallback for
"fsl,imx28-usbphy", "fsl,imx6q-usbphy", and "fsl,imx6sl-usbphy" in
existing DTs.
Is this expected going forward? It might be worth mentioning.
Otherwise this looks fine to me.
Thanks,
Mark.
next prev parent reply other threads:[~2014-02-21 9:13 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 5:14 [PATCH v10 00/15] Add power management support for mxs phy Peter Chen
2014-02-20 5:14 ` [PATCH v10 01/15] usb: doc: phy-mxs: Add more compatible strings Peter Chen
2014-02-21 9:13 ` Mark Rutland [this message]
2014-02-21 9:40 ` Peter Chen
2014-02-21 9:46 ` Marc Kleine-Budde
2014-02-21 9:05 ` Peter Chen
2014-02-21 12:38 ` Mark Rutland
2014-02-20 5:14 ` [PATCH v10 02/15] usb: phy-mxs: Add platform judgement code Peter Chen
2014-02-20 5:14 ` [PATCH v10 03/15] usb: phy-mxs: Add auto clock and power setting Peter Chen
2014-02-20 5:14 ` [PATCH v10 04/15] usb: doc: phy-mxs: update binding for adding anatop phandle Peter Chen
2014-02-21 9:14 ` Mark Rutland
2014-02-21 8:57 ` Peter Chen
2014-02-20 5:14 ` [PATCH v10 05/15] usb: phy-mxs: Add anatop regmap Peter Chen
2014-02-20 5:14 ` [PATCH v10 06/15] usb: phy-mxs: change description of usb device speed Peter Chen
2014-02-20 5:14 ` [PATCH v10 07/15] usb: phy-mxs: Enable IC fixes for related SoCs Peter Chen
2014-02-20 5:14 ` [PATCH v10 08/15] usb: phy-mxs: add controller id Peter Chen
2014-02-20 5:14 ` [PATCH v10 09/15] usb: phy: Add set_wakeup API Peter Chen
2014-02-20 5:14 ` [PATCH v10 10/15] usb: phy-mxs: Add implementation of set_wakeup Peter Chen
2014-02-21 9:21 ` Mark Rutland
2014-02-21 9:03 ` Peter Chen
2014-02-20 5:14 ` [PATCH v10 11/15] usb: phy-mxs: Add system suspend/resume API Peter Chen
2014-02-20 5:14 ` [PATCH v10 12/15] usb: phy-mxs: Add sync time after controller clear phcd Peter Chen
2014-02-20 5:14 ` [PATCH v10 13/15] ARM: dts: mxs: add mxs phy controller id Peter Chen
2014-02-20 5:14 ` [PATCH v10 14/15] ARM: dts: imx6: add anatop phandle for usbphy Peter Chen
2014-02-20 5:14 ` [PATCH v10 15/15] ARM: dts: imx6: add mxs phy controller id Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140221091345.GA7541@e106331-lin.cambridge.arm.com \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).