From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/2] ARM: OMAP4: Fix gpmc_fck clock
Date: Fri, 21 Feb 2014 15:23:23 -0800 [thread overview]
Message-ID: <20140221232323.GD5342@atomide.com> (raw)
In-Reply-To: <5305D02D.5020702@ti.com>
* Tero Kristo <t-kristo@ti.com> [140220 01:54]:
> On 02/19/2014 09:26 PM, Florian Vaussard wrote:
> >
> >On 02/19/2014 05:22 PM, Tero Kristo wrote:
> >>On 02/19/2014 11:15 AM, Florian Vaussard wrote:
> >>>Hello,
> >>>
> >>>Trying to get my SMSC9221 working on OMAP4 with DT,
> >>>I faced a misconfigured gpmc_fck (dummy clock set to 0)
> >>>resulting in serveral division-by-zero, misconfigured
> >>>timings and driver lost in the La La Land.
> >>>
> >>>To solve this, patch 1 removes gpmc_fck from the dummy
> >>>clocks, and patch 2 adds the gpmc_fck DT node and
> >>>reference it from the gpmc node.
> >>>
> >>>Tested on DuoVero/Parlor (OMAP4430) with SMSC9221.
> >>
> >>I can't test GPMC myself, but other than that, this set looks good to go.
> >>
> >
> >Thank you. Would you like more test coverage by other people? I would
> >like to see this in -rc if possible, as it is needed to boot my OMAP4
> >system.
>
> Well, I just think the driver clock change should be acked by
> someone who knows gpmc better than me.
Hmm do we also need to fix this for other omaps? We at least have
the following refrerences:
$ git grep dummy_ck drivers/ | grep -i gpmc
drivers/clk/ti/clk-44xx.c: DT_CLK("50000000.gpmc", "fck", "dummy_ck"),
drivers/clk/ti/clk-54xx.c: DT_CLK(NULL, "gpmc_ck", "dummy_ck"),
drivers/clk/ti/clk-7xx.c: DT_CLK(NULL, "gpmc_ck", "dummy_ck"),
Regards,
Tony
next prev parent reply other threads:[~2014-02-21 23:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 9:15 [PATCH v2 0/2] ARM: OMAP4: Fix gpmc_fck clock Florian Vaussard
2014-02-19 9:15 ` [PATCH v2 1/2] CLK: TI: OMAP4: Remove gpmc_fck from dummy clocks Florian Vaussard
2014-02-19 9:15 ` [PATCH v2 2/2] ARM: DTS: OMAP4: Use l3_ick for the gpmc node Florian Vaussard
2014-02-19 16:22 ` [PATCH v2 0/2] ARM: OMAP4: Fix gpmc_fck clock Tero Kristo
2014-02-19 19:26 ` Florian Vaussard
2014-02-20 9:51 ` Tero Kristo
2014-02-21 23:23 ` Tony Lindgren [this message]
2014-02-23 20:36 ` Florian Vaussard
[not found] ` <20140223212309.22529.75068@quantum>
2014-02-24 5:44 ` Florian Vaussard
[not found] ` <20140225062615.22529.88499@quantum>
2014-02-25 8:10 ` Florian Vaussard
2014-02-26 0:05 ` Suman Anna
2014-02-26 5:11 ` Florian Vaussard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140221232323.GD5342@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).