From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] ARM: mvebu: Add HP T5325 thin client
Date: Sun, 23 Feb 2014 18:34:17 +0100 [thread overview]
Message-ID: <20140223183417.306e17e6@skate> (raw)
In-Reply-To: <1393175982-18516-4-git-send-email-andrew@lunn.ch>
Dear Andrew Lunn,
Sorry, I'm in a nitpick mood it seems :)
On Sun, 23 Feb 2014 18:19:41 +0100, Andrew Lunn wrote:
> + button at 1 {
> + label = "Power Button";
> + linux,code = < KEY_POWER >;
Why spaces before and after KEY_POWER ?
> +config MACH_T5325
> + bool "HP T5325 thin client"
> + depends on MACH_KIRKWOOD
> + help
> + Say 'Y' here if you want your kernel to support the
> + HP T5325 Thin client
Indentation for help text should be one tab and two spaces.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-02-23 17:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-23 17:19 [PATCH 0/4] mvebu support for kirkwood HP T5325 Andrew Lunn
2014-02-23 17:19 ` [PATCH 1/4] ARM: Kirkwood: Add audio node to kirkwood.dtsi Andrew Lunn
2014-02-23 17:31 ` Thomas Petazzoni
2014-02-23 17:34 ` Sergei Shtylyov
2014-02-23 17:19 ` [PATCH 2/4] ARM: mvebu: Add i2c alias so setting bus number Andrew Lunn
2014-02-23 17:19 ` [PATCH 3/4] ARM: mvebu: Add HP T5325 thin client Andrew Lunn
2014-02-23 17:30 ` Jason Cooper
2014-02-23 17:34 ` Thomas Petazzoni [this message]
2014-02-23 17:19 ` [PATCH 4/4] ARM: mvebu: Add HP T5325 devices to {multi|mvebu}_v5_defconfig Andrew Lunn
2014-02-23 17:33 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140223183417.306e17e6@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).