* [PATCH] watchdog: orion_wdt: Use %pa to print 'phys_addr_t'
2014-02-25 15:09 ` [PATCH] watchdog: orion_wdt: Use %pa to print 'phys_addr_t' Ezequiel Garcia
@ 2014-02-25 16:07 ` Jason Cooper
2014-02-25 16:10 ` Jason Cooper
1 sibling, 0 replies; 3+ messages in thread
From: Jason Cooper @ 2014-02-25 16:07 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Feb 25, 2014 at 12:09:48PM -0300, Ezequiel Garcia wrote:
> Jason,
>
> On Mon, Feb 24, 2014 at 09:33:52PM +0100, Wim Van Sebroeck wrote:
> > > When building an ARM multi_v7_defconfig with LPAE option selected we get the
> > > following build warning:
> > >
> > > drivers/watchdog/orion_wdt.c:272:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'phys_addr_t' [-Wformat=]
> > >
> > > Fix it by using %pa to print 'phys_addr_t'.
> > >
> > > Reported-by: Olof's autobuilder <build@lixom.net>
> > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> > > ---
> > > drivers/watchdog/orion_wdt.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/watchdog/orion_wdt.c b/drivers/watchdog/orion_wdt.c
> > > index 15321aa..6f9b4c6 100644
> > > --- a/drivers/watchdog/orion_wdt.c
> > > +++ b/drivers/watchdog/orion_wdt.c
> > > @@ -269,7 +269,7 @@ static void __iomem *orion_wdt_ioremap_rstout(struct platform_device *pdev,
> > >
> > > rstout = internal_regs + ORION_RSTOUT_MASK_OFFSET;
> > >
> > > - WARN(1, FW_BUG "falling back to harcoded RSTOUT reg 0x%x\n", rstout);
> > > + WARN(1, FW_BUG "falling back to harcoded RSTOUT reg %pa\n", &rstout);
> > > return devm_ioremap(&pdev->dev, rstout, 0x4);
> > > }
> > >
> > > --
> > > 1.8.1.2
> > >
> > >
> >
> > Acked-by me also, but can this also go via the mvebu tree (since the patch that introduces this is also there??
> >
>
> Can you pull this too? It's been acked by Wim and me.
Yep, I'll add it onto the stack.
thx,
Jason.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] watchdog: orion_wdt: Use %pa to print 'phys_addr_t'
2014-02-25 15:09 ` [PATCH] watchdog: orion_wdt: Use %pa to print 'phys_addr_t' Ezequiel Garcia
2014-02-25 16:07 ` Jason Cooper
@ 2014-02-25 16:10 ` Jason Cooper
1 sibling, 0 replies; 3+ messages in thread
From: Jason Cooper @ 2014-02-25 16:10 UTC (permalink / raw)
To: linux-arm-kernel
Fabio,
On Tue, Feb 25, 2014 at 12:09:48PM -0300, Ezequiel Garcia wrote:
> Jason,
>
> On Mon, Feb 24, 2014 at 09:33:52PM +0100, Wim Van Sebroeck wrote:
> > > When building an ARM multi_v7_defconfig with LPAE option selected we get the
> > > following build warning:
> > >
> > > drivers/watchdog/orion_wdt.c:272:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'phys_addr_t' [-Wformat=]
> > >
> > > Fix it by using %pa to print 'phys_addr_t'.
> > >
> > > Reported-by: Olof's autobuilder <build@lixom.net>
> > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> > > ---
> > > drivers/watchdog/orion_wdt.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/watchdog/orion_wdt.c b/drivers/watchdog/orion_wdt.c
> > > index 15321aa..6f9b4c6 100644
> > > --- a/drivers/watchdog/orion_wdt.c
> > > +++ b/drivers/watchdog/orion_wdt.c
> > > @@ -269,7 +269,7 @@ static void __iomem *orion_wdt_ioremap_rstout(struct platform_device *pdev,
> > >
> > > rstout = internal_regs + ORION_RSTOUT_MASK_OFFSET;
> > >
> > > - WARN(1, FW_BUG "falling back to harcoded RSTOUT reg 0x%x\n", rstout);
> > > + WARN(1, FW_BUG "falling back to harcoded RSTOUT reg %pa\n", &rstout);
> > > return devm_ioremap(&pdev->dev, rstout, 0x4);
> > > }
> > >
> > > --
> > > 1.8.1.2
> > >
> > >
> >
> > Acked-by me also, but can this also go via the mvebu tree (since the patch that introduces this is also there??
> >
>
> Can you pull this too? It's been acked by Wim and me.
I don't have a local archive of the watchdog ML, could you resend the
patch to me?
thx,
Jason.
^ permalink raw reply [flat|nested] 3+ messages in thread