linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: jason@lakedaemon.net (Jason Cooper)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] watchdog: orion_wdt: Use %pa to print 'phys_addr_t'
Date: Tue, 25 Feb 2014 11:07:30 -0500	[thread overview]
Message-ID: <20140225160729.GK1010@titan.lakedaemon.net> (raw)
In-Reply-To: <20140225150947.GA22740@localhost>

On Tue, Feb 25, 2014 at 12:09:48PM -0300, Ezequiel Garcia wrote:
> Jason,
> 
> On Mon, Feb 24, 2014 at 09:33:52PM +0100, Wim Van Sebroeck wrote:
> > > When building an ARM multi_v7_defconfig with LPAE option selected we get the
> > > following build warning:
> > > 
> > > drivers/watchdog/orion_wdt.c:272:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'phys_addr_t' [-Wformat=]
> > > 
> > > Fix it by using %pa to print 'phys_addr_t'.
> > > 
> > > Reported-by: Olof's autobuilder <build@lixom.net>
> > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> > > ---
> > >  drivers/watchdog/orion_wdt.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/watchdog/orion_wdt.c b/drivers/watchdog/orion_wdt.c
> > > index 15321aa..6f9b4c6 100644
> > > --- a/drivers/watchdog/orion_wdt.c
> > > +++ b/drivers/watchdog/orion_wdt.c
> > > @@ -269,7 +269,7 @@ static void __iomem *orion_wdt_ioremap_rstout(struct platform_device *pdev,
> > >  
> > >  	rstout = internal_regs + ORION_RSTOUT_MASK_OFFSET;
> > >  
> > > -	WARN(1, FW_BUG "falling back to harcoded RSTOUT reg 0x%x\n", rstout);
> > > +	WARN(1, FW_BUG "falling back to harcoded RSTOUT reg %pa\n", &rstout);
> > >  	return devm_ioremap(&pdev->dev, rstout, 0x4);
> > >  }
> > >  
> > > -- 
> > > 1.8.1.2
> > > 
> > > 
> > 
> > Acked-by me also, but can this also go via the mvebu tree (since the patch that introduces this is also there??
> > 
> 
> Can you pull this too? It's been acked by Wim and me.

Yep, I'll add it onto the stack.

thx,

Jason.

  reply	other threads:[~2014-02-25 16:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1392726234-16977-1-git-send-email-fabio.estevam@freescale.com>
     [not found] ` <20140224203352.GA21204@spo001.leaseweb.com>
2014-02-25 15:09   ` [PATCH] watchdog: orion_wdt: Use %pa to print 'phys_addr_t' Ezequiel Garcia
2014-02-25 16:07     ` Jason Cooper [this message]
2014-02-25 16:10     ` Jason Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140225160729.GK1010@titan.lakedaemon.net \
    --to=jason@lakedaemon.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).