* [PATCH 1/7] Documentation: dt: iio: improve atmel-adc documentation
@ 2014-02-26 17:01 Alexandre Belloni
2014-02-26 17:01 ` [PATCH 2/7] Documentation: dt: iio: move arm/atmel-adc.txt to iio/adc/at91_adc.txt Alexandre Belloni
` (6 more replies)
0 siblings, 7 replies; 9+ messages in thread
From: Alexandre Belloni @ 2014-02-26 17:01 UTC (permalink / raw)
To: linux-arm-kernel
This corrects the example by removing the unit-address, as suggested by Mark
Rutland in
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-February/234184.html
Also, it removes the properties that are not used anymore, to stop propagating
them.
Finally, fixes a few typos.
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
.../devicetree/bindings/arm/atmel-adc.txt | 29 +++++++++-------------
1 file changed, 12 insertions(+), 17 deletions(-)
diff --git a/Documentation/devicetree/bindings/arm/atmel-adc.txt b/Documentation/devicetree/bindings/arm/atmel-adc.txt
index d1061469f63d..ba3abfad656b 100644
--- a/Documentation/devicetree/bindings/arm/atmel-adc.txt
+++ b/Documentation/devicetree/bindings/arm/atmel-adc.txt
@@ -5,31 +5,31 @@ Required properties:
<chip> can be "at91sam9260", "at91sam9g45" or "at91sam9x5"
- reg: Should contain ADC registers location and length
- interrupts: Should contain the IRQ line for the ADC
- - atmel,adc-channels-used: Bitmask of the channels muxed and enable for this
+ - atmel,adc-channels-used: Bitmask of the channels muxed and enabled for this
device
- atmel,adc-startup-time: Startup Time of the ADC in microseconds as
defined in the datasheet
- atmel,adc-vref: Reference voltage in millivolts for the conversions
- - atmel,adc-res: List of resolution in bits supported by the ADC. List size
+ - atmel,adc-res: List of resolutions in bits supported by the ADC. List size
must be two at least.
- atmel,adc-res-names: Contains one identifier string for each resolution
in atmel,adc-res property. "lowres" and "highres"
identifiers are required.
Optional properties:
- - atmel,adc-use-external: Boolean to enable of external triggers
+ - atmel,adc-use-external: Boolean to enable the external triggers
- atmel,adc-use-res: String corresponding to an identifier from
atmel,adc-res-names property. If not specified, the highest
resolution will be used.
- atmel,adc-sleep-mode: Boolean to enable sleep mode when no conversion
- atmel,adc-sample-hold-time: Sample and Hold Time in microseconds
- - atmel,adc-ts-wires: Number of touch screen wires. Should be 4 or 5. If this
- value is set, then adc driver will enable touch screen
+ - atmel,adc-ts-wires: Number of touchscreen wires. Should be 4 or 5. If this
+ value is set, then the adc driver will enable touchscreen
support.
- NOTE: when adc touch screen enabled, the adc hardware trigger will be
- disabled. Since touch screen will occupied the trigger register.
+ NOTE: when adc touchscreen is enabled, the adc hardware trigger will be
+ disabled. Since touchscreen will occupy the trigger register.
- atmel,adc-ts-pressure-threshold: a pressure threshold for touchscreen. It
- make touch detect more precision.
+ makes touch detection more precise.
Optional trigger Nodes:
- Required properties:
@@ -44,37 +44,32 @@ adc0: adc at fffb0000 {
compatible = "atmel,at91sam9260-adc";
reg = <0xfffb0000 0x100>;
interrupts = <20 4>;
- atmel,adc-channel-base = <0x30>;
atmel,adc-channels-used = <0xff>;
- atmel,adc-drdy-mask = <0x10000>;
- atmel,adc-num-channels = <8>;
atmel,adc-startup-time = <40>;
- atmel,adc-status-register = <0x1c>;
- atmel,adc-trigger-register = <0x08>;
atmel,adc-use-external;
atmel,adc-vref = <3300>;
atmel,adc-res = <8 10>;
atmel,adc-res-names = "lowres", "highres";
atmel,adc-use-res = "lowres";
- trigger at 0 {
+ trigger0 {
trigger-name = "external-rising";
trigger-value = <0x1>;
trigger-external;
};
- trigger at 1 {
+ trigger1 {
trigger-name = "external-falling";
trigger-value = <0x2>;
trigger-external;
};
- trigger at 2 {
+ trigger2 {
trigger-name = "external-any";
trigger-value = <0x3>;
trigger-external;
};
- trigger at 3 {
+ trigger3 {
trigger-name = "continuous";
trigger-value = <0x6>;
};
--
1.8.3.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/7] Documentation: dt: iio: move arm/atmel-adc.txt to iio/adc/at91_adc.txt
2014-02-26 17:01 [PATCH 1/7] Documentation: dt: iio: improve atmel-adc documentation Alexandre Belloni
@ 2014-02-26 17:01 ` Alexandre Belloni
2014-02-26 17:01 ` [PATCH 3/7] ARM: at91/dt: at91-ariag25: remove useless adc properties Alexandre Belloni
` (5 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Alexandre Belloni @ 2014-02-26 17:01 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
.../devicetree/bindings/arm/atmel-adc.txt | 76 ----------------------
.../devicetree/bindings/iio/adc/at91_adc.txt | 76 ++++++++++++++++++++++
2 files changed, 76 insertions(+), 76 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/arm/atmel-adc.txt
create mode 100644 Documentation/devicetree/bindings/iio/adc/at91_adc.txt
diff --git a/Documentation/devicetree/bindings/arm/atmel-adc.txt b/Documentation/devicetree/bindings/arm/atmel-adc.txt
deleted file mode 100644
index ba3abfad656b..000000000000
--- a/Documentation/devicetree/bindings/arm/atmel-adc.txt
+++ /dev/null
@@ -1,76 +0,0 @@
-* AT91's Analog to Digital Converter (ADC)
-
-Required properties:
- - compatible: Should be "atmel,<chip>-adc"
- <chip> can be "at91sam9260", "at91sam9g45" or "at91sam9x5"
- - reg: Should contain ADC registers location and length
- - interrupts: Should contain the IRQ line for the ADC
- - atmel,adc-channels-used: Bitmask of the channels muxed and enabled for this
- device
- - atmel,adc-startup-time: Startup Time of the ADC in microseconds as
- defined in the datasheet
- - atmel,adc-vref: Reference voltage in millivolts for the conversions
- - atmel,adc-res: List of resolutions in bits supported by the ADC. List size
- must be two at least.
- - atmel,adc-res-names: Contains one identifier string for each resolution
- in atmel,adc-res property. "lowres" and "highres"
- identifiers are required.
-
-Optional properties:
- - atmel,adc-use-external: Boolean to enable the external triggers
- - atmel,adc-use-res: String corresponding to an identifier from
- atmel,adc-res-names property. If not specified, the highest
- resolution will be used.
- - atmel,adc-sleep-mode: Boolean to enable sleep mode when no conversion
- - atmel,adc-sample-hold-time: Sample and Hold Time in microseconds
- - atmel,adc-ts-wires: Number of touchscreen wires. Should be 4 or 5. If this
- value is set, then the adc driver will enable touchscreen
- support.
- NOTE: when adc touchscreen is enabled, the adc hardware trigger will be
- disabled. Since touchscreen will occupy the trigger register.
- - atmel,adc-ts-pressure-threshold: a pressure threshold for touchscreen. It
- makes touch detection more precise.
-
-Optional trigger Nodes:
- - Required properties:
- * trigger-name: Name of the trigger exposed to the user
- * trigger-value: Value to put in the Trigger register
- to activate this trigger
- - Optional properties:
- * trigger-external: Is the trigger an external trigger?
-
-Examples:
-adc0: adc at fffb0000 {
- compatible = "atmel,at91sam9260-adc";
- reg = <0xfffb0000 0x100>;
- interrupts = <20 4>;
- atmel,adc-channels-used = <0xff>;
- atmel,adc-startup-time = <40>;
- atmel,adc-use-external;
- atmel,adc-vref = <3300>;
- atmel,adc-res = <8 10>;
- atmel,adc-res-names = "lowres", "highres";
- atmel,adc-use-res = "lowres";
-
- trigger0 {
- trigger-name = "external-rising";
- trigger-value = <0x1>;
- trigger-external;
- };
- trigger1 {
- trigger-name = "external-falling";
- trigger-value = <0x2>;
- trigger-external;
- };
-
- trigger2 {
- trigger-name = "external-any";
- trigger-value = <0x3>;
- trigger-external;
- };
-
- trigger3 {
- trigger-name = "continuous";
- trigger-value = <0x6>;
- };
-};
diff --git a/Documentation/devicetree/bindings/iio/adc/at91_adc.txt b/Documentation/devicetree/bindings/iio/adc/at91_adc.txt
new file mode 100644
index 000000000000..ba3abfad656b
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/adc/at91_adc.txt
@@ -0,0 +1,76 @@
+* AT91's Analog to Digital Converter (ADC)
+
+Required properties:
+ - compatible: Should be "atmel,<chip>-adc"
+ <chip> can be "at91sam9260", "at91sam9g45" or "at91sam9x5"
+ - reg: Should contain ADC registers location and length
+ - interrupts: Should contain the IRQ line for the ADC
+ - atmel,adc-channels-used: Bitmask of the channels muxed and enabled for this
+ device
+ - atmel,adc-startup-time: Startup Time of the ADC in microseconds as
+ defined in the datasheet
+ - atmel,adc-vref: Reference voltage in millivolts for the conversions
+ - atmel,adc-res: List of resolutions in bits supported by the ADC. List size
+ must be two at least.
+ - atmel,adc-res-names: Contains one identifier string for each resolution
+ in atmel,adc-res property. "lowres" and "highres"
+ identifiers are required.
+
+Optional properties:
+ - atmel,adc-use-external: Boolean to enable the external triggers
+ - atmel,adc-use-res: String corresponding to an identifier from
+ atmel,adc-res-names property. If not specified, the highest
+ resolution will be used.
+ - atmel,adc-sleep-mode: Boolean to enable sleep mode when no conversion
+ - atmel,adc-sample-hold-time: Sample and Hold Time in microseconds
+ - atmel,adc-ts-wires: Number of touchscreen wires. Should be 4 or 5. If this
+ value is set, then the adc driver will enable touchscreen
+ support.
+ NOTE: when adc touchscreen is enabled, the adc hardware trigger will be
+ disabled. Since touchscreen will occupy the trigger register.
+ - atmel,adc-ts-pressure-threshold: a pressure threshold for touchscreen. It
+ makes touch detection more precise.
+
+Optional trigger Nodes:
+ - Required properties:
+ * trigger-name: Name of the trigger exposed to the user
+ * trigger-value: Value to put in the Trigger register
+ to activate this trigger
+ - Optional properties:
+ * trigger-external: Is the trigger an external trigger?
+
+Examples:
+adc0: adc at fffb0000 {
+ compatible = "atmel,at91sam9260-adc";
+ reg = <0xfffb0000 0x100>;
+ interrupts = <20 4>;
+ atmel,adc-channels-used = <0xff>;
+ atmel,adc-startup-time = <40>;
+ atmel,adc-use-external;
+ atmel,adc-vref = <3300>;
+ atmel,adc-res = <8 10>;
+ atmel,adc-res-names = "lowres", "highres";
+ atmel,adc-use-res = "lowres";
+
+ trigger0 {
+ trigger-name = "external-rising";
+ trigger-value = <0x1>;
+ trigger-external;
+ };
+ trigger1 {
+ trigger-name = "external-falling";
+ trigger-value = <0x2>;
+ trigger-external;
+ };
+
+ trigger2 {
+ trigger-name = "external-any";
+ trigger-value = <0x3>;
+ trigger-external;
+ };
+
+ trigger3 {
+ trigger-name = "continuous";
+ trigger-value = <0x6>;
+ };
+};
--
1.8.3.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 3/7] ARM: at91/dt: at91-ariag25: remove useless adc properties
2014-02-26 17:01 [PATCH 1/7] Documentation: dt: iio: improve atmel-adc documentation Alexandre Belloni
2014-02-26 17:01 ` [PATCH 2/7] Documentation: dt: iio: move arm/atmel-adc.txt to iio/adc/at91_adc.txt Alexandre Belloni
@ 2014-02-26 17:01 ` Alexandre Belloni
2014-02-26 17:01 ` [PATCH 4/7] ARM: at91/dt: at91sam9260: " Alexandre Belloni
` (4 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Alexandre Belloni @ 2014-02-26 17:01 UTC (permalink / raw)
To: linux-arm-kernel
Remove the properties that are not used anymore by the at91_adc driver.
Also, stop using unit-addresses for the triggers as suggested by Mark
Rutland in
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-February/234184.html
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
arch/arm/boot/dts/at91-ariag25.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/boot/dts/at91-ariag25.dts b/arch/arm/boot/dts/at91-ariag25.dts
index cce45f5177f9..55ab6180e350 100644
--- a/arch/arm/boot/dts/at91-ariag25.dts
+++ b/arch/arm/boot/dts/at91-ariag25.dts
@@ -129,7 +129,6 @@
adc0: adc at f804c000 {
status = "okay";
atmel,adc-channels-used = <0xf>;
- atmel,adc-num-channels = <4>;
};
dbgu: serial at fffff200 {
--
1.8.3.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 4/7] ARM: at91/dt: at91sam9260: remove useless adc properties
2014-02-26 17:01 [PATCH 1/7] Documentation: dt: iio: improve atmel-adc documentation Alexandre Belloni
2014-02-26 17:01 ` [PATCH 2/7] Documentation: dt: iio: move arm/atmel-adc.txt to iio/adc/at91_adc.txt Alexandre Belloni
2014-02-26 17:01 ` [PATCH 3/7] ARM: at91/dt: at91-ariag25: remove useless adc properties Alexandre Belloni
@ 2014-02-26 17:01 ` Alexandre Belloni
2014-02-26 17:01 ` [PATCH 5/7] ARM: at91/dt: at91sam9g45: " Alexandre Belloni
` (3 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Alexandre Belloni @ 2014-02-26 17:01 UTC (permalink / raw)
To: linux-arm-kernel
Remove the properties that are not used anymore by the at91_adc driver.
Also, stop using unit-addresses for the triggers as suggested by Mark
Rutland in
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-February/234184.html
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
arch/arm/boot/dts/at91sam9260.dtsi | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/arch/arm/boot/dts/at91sam9260.dtsi b/arch/arm/boot/dts/at91sam9260.dtsi
index 997901f7ed73..ac1533368cb5 100644
--- a/arch/arm/boot/dts/at91sam9260.dtsi
+++ b/arch/arm/boot/dts/at91sam9260.dtsi
@@ -614,31 +614,26 @@
atmel,adc-use-external-triggers;
atmel,adc-channels-used = <0xf>;
atmel,adc-vref = <3300>;
- atmel,adc-num-channels = <4>;
atmel,adc-startup-time = <15>;
- atmel,adc-channel-base = <0x30>;
- atmel,adc-drdy-mask = <0x10000>;
- atmel,adc-status-register = <0x1c>;
- atmel,adc-trigger-register = <0x04>;
atmel,adc-res = <8 10>;
atmel,adc-res-names = "lowres", "highres";
atmel,adc-use-res = "highres";
- trigger at 0 {
+ trigger0 {
trigger-name = "timer-counter-0";
trigger-value = <0x1>;
};
- trigger at 1 {
+ trigger1 {
trigger-name = "timer-counter-1";
trigger-value = <0x3>;
};
- trigger at 2 {
+ trigger2 {
trigger-name = "timer-counter-2";
trigger-value = <0x5>;
};
- trigger at 3 {
+ trigger3 {
trigger-name = "external";
trigger-value = <0x13>;
trigger-external;
--
1.8.3.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 5/7] ARM: at91/dt: at91sam9g45: remove useless adc properties
2014-02-26 17:01 [PATCH 1/7] Documentation: dt: iio: improve atmel-adc documentation Alexandre Belloni
` (2 preceding siblings ...)
2014-02-26 17:01 ` [PATCH 4/7] ARM: at91/dt: at91sam9260: " Alexandre Belloni
@ 2014-02-26 17:01 ` Alexandre Belloni
2014-02-26 17:01 ` [PATCH 6/7] ARM: at91/dt: at91sam9x5: " Alexandre Belloni
` (2 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Alexandre Belloni @ 2014-02-26 17:01 UTC (permalink / raw)
To: linux-arm-kernel
Remove the properties that are not used anymore by the at91_adc driver.
Also, stop using unit-addresses for the triggers as suggested by Mark
Rutland in
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-February/234184.html
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
arch/arm/boot/dts/at91sam9g45.dtsi | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/arch/arm/boot/dts/at91sam9g45.dtsi b/arch/arm/boot/dts/at91sam9g45.dtsi
index cbcc058b26b4..715187692577 100644
--- a/arch/arm/boot/dts/at91sam9g45.dtsi
+++ b/arch/arm/boot/dts/at91sam9g45.dtsi
@@ -638,34 +638,29 @@
atmel,adc-use-external-triggers;
atmel,adc-channels-used = <0xff>;
atmel,adc-vref = <3300>;
- atmel,adc-num-channels = <8>;
atmel,adc-startup-time = <40>;
- atmel,adc-channel-base = <0x30>;
- atmel,adc-drdy-mask = <0x10000>;
- atmel,adc-status-register = <0x1c>;
- atmel,adc-trigger-register = <0x08>;
atmel,adc-res = <8 10>;
atmel,adc-res-names = "lowres", "highres";
atmel,adc-use-res = "highres";
- trigger at 0 {
+ trigger0 {
trigger-name = "external-rising";
trigger-value = <0x1>;
trigger-external;
};
- trigger at 1 {
+ trigger1 {
trigger-name = "external-falling";
trigger-value = <0x2>;
trigger-external;
};
- trigger at 2 {
+ trigger2 {
trigger-name = "external-any";
trigger-value = <0x3>;
trigger-external;
};
- trigger at 3 {
+ trigger3 {
trigger-name = "continuous";
trigger-value = <0x6>;
};
--
1.8.3.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 6/7] ARM: at91/dt: at91sam9x5: remove useless adc properties
2014-02-26 17:01 [PATCH 1/7] Documentation: dt: iio: improve atmel-adc documentation Alexandre Belloni
` (3 preceding siblings ...)
2014-02-26 17:01 ` [PATCH 5/7] ARM: at91/dt: at91sam9g45: " Alexandre Belloni
@ 2014-02-26 17:01 ` Alexandre Belloni
2014-02-26 17:01 ` [PATCH 7/7] ARM: at91/dt: sama5d3: " Alexandre Belloni
2014-02-26 17:39 ` [PATCH 1/7] Documentation: dt: iio: improve atmel-adc documentation Maxime Ripard
6 siblings, 0 replies; 9+ messages in thread
From: Alexandre Belloni @ 2014-02-26 17:01 UTC (permalink / raw)
To: linux-arm-kernel
Remove the properties that are not used anymore by the at91_adc driver.
Also, stop using unit-addresses for the triggers as suggested by Mark
Rutland in
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-February/234184.html
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
arch/arm/boot/dts/at91sam9x5.dtsi | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi
index 174219de92fa..a535c905d9d4 100644
--- a/arch/arm/boot/dts/at91sam9x5.dtsi
+++ b/arch/arm/boot/dts/at91sam9x5.dtsi
@@ -627,35 +627,30 @@
atmel,adc-use-external;
atmel,adc-channels-used = <0xffff>;
atmel,adc-vref = <3300>;
- atmel,adc-num-channels = <12>;
atmel,adc-startup-time = <40>;
- atmel,adc-channel-base = <0x50>;
- atmel,adc-drdy-mask = <0x1000000>;
- atmel,adc-status-register = <0x30>;
- atmel,adc-trigger-register = <0xc0>;
atmel,adc-res = <8 10>;
atmel,adc-res-names = "lowres", "highres";
atmel,adc-use-res = "highres";
- trigger at 0 {
+ trigger0 {
trigger-name = "external-rising";
trigger-value = <0x1>;
trigger-external;
};
- trigger at 1 {
+ trigger1 {
trigger-name = "external-falling";
trigger-value = <0x2>;
trigger-external;
};
- trigger at 2 {
+ trigger2 {
trigger-name = "external-any";
trigger-value = <0x3>;
trigger-external;
};
- trigger at 3 {
+ trigger3 {
trigger-name = "continuous";
trigger-value = <0x6>;
};
--
1.8.3.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 7/7] ARM: at91/dt: sama5d3: remove useless adc properties
2014-02-26 17:01 [PATCH 1/7] Documentation: dt: iio: improve atmel-adc documentation Alexandre Belloni
` (4 preceding siblings ...)
2014-02-26 17:01 ` [PATCH 6/7] ARM: at91/dt: at91sam9x5: " Alexandre Belloni
@ 2014-02-26 17:01 ` Alexandre Belloni
2014-02-26 17:39 ` [PATCH 1/7] Documentation: dt: iio: improve atmel-adc documentation Maxime Ripard
6 siblings, 0 replies; 9+ messages in thread
From: Alexandre Belloni @ 2014-02-26 17:01 UTC (permalink / raw)
To: linux-arm-kernel
Remove the properties that are not used anymore by the at91_adc driver.
Also, stop using unit-addresses for the triggers as suggested by Mark
Rutland in
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-February/234184.html
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
arch/arm/boot/dts/sama5d3.dtsi | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/arch/arm/boot/dts/sama5d3.dtsi b/arch/arm/boot/dts/sama5d3.dtsi
index 26d7ed510c96..46f610a09b38 100644
--- a/arch/arm/boot/dts/sama5d3.dtsi
+++ b/arch/arm/boot/dts/sama5d3.dtsi
@@ -261,35 +261,30 @@
clocks = <&adc_clk>,
<&adc_op_clk>;
clock-names = "adc_clk", "adc_op_clk";
- atmel,adc-channel-base = <0x50>;
atmel,adc-channels-used = <0xfff>;
- atmel,adc-drdy-mask = <0x1000000>;
- atmel,adc-num-channels = <12>;
atmel,adc-startup-time = <40>;
- atmel,adc-status-register = <0x30>;
- atmel,adc-trigger-register = <0xc0>;
atmel,adc-use-external;
atmel,adc-vref = <3000>;
atmel,adc-res = <10 12>;
atmel,adc-res-names = "lowres", "highres";
status = "disabled";
- trigger at 0 {
+ trigger0 {
trigger-name = "external-rising";
trigger-value = <0x1>;
trigger-external;
};
- trigger at 1 {
+ trigger1 {
trigger-name = "external-falling";
trigger-value = <0x2>;
trigger-external;
};
- trigger at 2 {
+ trigger2 {
trigger-name = "external-any";
trigger-value = <0x3>;
trigger-external;
};
- trigger at 3 {
+ trigger3 {
trigger-name = "continuous";
trigger-value = <0x6>;
};
--
1.8.3.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 1/7] Documentation: dt: iio: improve atmel-adc documentation
2014-02-26 17:01 [PATCH 1/7] Documentation: dt: iio: improve atmel-adc documentation Alexandre Belloni
` (5 preceding siblings ...)
2014-02-26 17:01 ` [PATCH 7/7] ARM: at91/dt: sama5d3: " Alexandre Belloni
@ 2014-02-26 17:39 ` Maxime Ripard
2014-02-26 21:00 ` Alexandre Belloni
6 siblings, 1 reply; 9+ messages in thread
From: Maxime Ripard @ 2014-02-26 17:39 UTC (permalink / raw)
To: linux-arm-kernel
Hi Alexandre,
On Wed, Feb 26, 2014 at 06:01:08PM +0100, Alexandre Belloni wrote:
> This corrects the example by removing the unit-address, as suggested by Mark
> Rutland in
> http://lists.infradead.org/pipermail/linux-arm-kernel/2014-February/234184.html
I still belive that it's wrong, and Mark haven't answered my comments
on his statement.
I'd vote for a status-quo, until he gives an answer backed with
references to the ePAPR.
>
> Also, it removes the properties that are not used anymore, to stop propagating
> them.
>
> Finally, fixes a few typos.
I'm fine with the rest.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140226/ff2efc4a/attachment-0001.sig>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/7] Documentation: dt: iio: improve atmel-adc documentation
2014-02-26 17:39 ` [PATCH 1/7] Documentation: dt: iio: improve atmel-adc documentation Maxime Ripard
@ 2014-02-26 21:00 ` Alexandre Belloni
0 siblings, 0 replies; 9+ messages in thread
From: Alexandre Belloni @ 2014-02-26 21:00 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On 26/02/2014 at 18:39:04 +0100, Maxime Ripard wrote :
> Hi Alexandre,
>
> On Wed, Feb 26, 2014 at 06:01:08PM +0100, Alexandre Belloni wrote:
> > This corrects the example by removing the unit-address, as suggested by Mark
> > Rutland in
> > http://lists.infradead.org/pipermail/linux-arm-kernel/2014-February/234184.html
>
> I still belive that it's wrong, and Mark haven't answered my comments
> on his statement.
>
After our discussion, I'll go for the other suggestion, I'll add
#address-cells, #size-cells and a reg for each trigger.
> I'd vote for a status-quo, until he gives an answer backed with
> references to the ePAPR.
>
> >
> > Also, it removes the properties that are not used anymore, to stop propagating
> > them.
> >
> > Finally, fixes a few typos.
>
> I'm fine with the rest.
>
> Maxime
>
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140226/0202b047/attachment.sig>
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-02-26 21:00 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-26 17:01 [PATCH 1/7] Documentation: dt: iio: improve atmel-adc documentation Alexandre Belloni
2014-02-26 17:01 ` [PATCH 2/7] Documentation: dt: iio: move arm/atmel-adc.txt to iio/adc/at91_adc.txt Alexandre Belloni
2014-02-26 17:01 ` [PATCH 3/7] ARM: at91/dt: at91-ariag25: remove useless adc properties Alexandre Belloni
2014-02-26 17:01 ` [PATCH 4/7] ARM: at91/dt: at91sam9260: " Alexandre Belloni
2014-02-26 17:01 ` [PATCH 5/7] ARM: at91/dt: at91sam9g45: " Alexandre Belloni
2014-02-26 17:01 ` [PATCH 6/7] ARM: at91/dt: at91sam9x5: " Alexandre Belloni
2014-02-26 17:01 ` [PATCH 7/7] ARM: at91/dt: sama5d3: " Alexandre Belloni
2014-02-26 17:39 ` [PATCH 1/7] Documentation: dt: iio: improve atmel-adc documentation Maxime Ripard
2014-02-26 21:00 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).