From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] net: phy: add suspend_halted module param
Date: Wed, 26 Feb 2014 21:22:22 +0100 [thread overview]
Message-ID: <20140226202222.GD14907@lunn.ch> (raw)
In-Reply-To: <CAGVrzcb5k1JUPo0kvMdPJLCkWHb9qfHfDif08ud5ydKiKBwdHQ@mail.gmail.com>
> The only case we need to handle is when the interface is brought down,
> suspend_halted=true will also power down the PHY, you reboot into
> u-boot, and you attempt a network boot right after that, in that case
> the PHY interface is still powered down and this does not work.
Correct. And since my device uses dhclient, the interface is always
put down on reboot when it releases the lease.
> That could be worked around by putting the interface up again before
> you reboot into u-boot right, that specific logic being gated by
> reading the board model. Agreed, you need to duplicate that workaround
> in all affected user-space....
I wonder how many other systems are broken? Are we considering this a
regression? Should this feature to turned off by default, and a sysfs
knob used to enable it? That is the safe option.
Andrew
next prev parent reply other threads:[~2014-02-26 20:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-23 16:58 [PATCH] net: phy: add suspend_halted module param Sebastian Hesselbarth
2014-02-24 18:20 ` Florian Fainelli
2014-02-24 23:05 ` David Miller
2014-02-24 23:34 ` Sebastian Hesselbarth
2014-02-24 19:15 ` Andrew Lunn
2014-02-24 19:37 ` Florian Fainelli
2014-02-24 19:39 ` Andrew Lunn
2014-02-25 22:38 ` Sebastian Hesselbarth
2014-02-26 18:21 ` Andrew Lunn
2014-02-26 18:30 ` Florian Fainelli
2014-02-26 19:10 ` Andrew Lunn
2014-02-26 19:35 ` Florian Fainelli
2014-02-26 20:22 ` Andrew Lunn [this message]
2014-03-07 11:34 ` [PATCH] net: phy: Add sysfs attribute to prevent PHY suspend Sebastian Hesselbarth
2014-03-08 1:09 ` Florian Fainelli
2014-03-09 23:12 ` David Miller
2014-03-09 23:25 ` Sebastian Hesselbarth
2014-03-10 0:30 ` David Miller
2014-03-10 0:37 ` Sebastian Hesselbarth
2014-03-10 0:41 ` David Miller
2014-03-10 0:53 ` Sebastian Hesselbarth
2014-03-10 3:40 ` David Miller
2014-03-10 10:28 ` Sebastian Hesselbarth
2014-03-10 14:25 ` One Thousand Gnomes
2014-03-10 16:56 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140226202222.GD14907@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).