From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/2] ARM: avoid tracers in soft_restart
Date: Wed, 26 Feb 2014 23:37:44 +0000 [thread overview]
Message-ID: <20140226233744.GG21483@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1393441857-15472-2-git-send-email-sebastian.capella@linaro.org>
On Wed, Feb 26, 2014 at 11:10:56AM -0800, Sebastian Capella wrote:
> Use of tracers in local_irq_disable is causes recursive aborts when
> called with irqs disabled and using a temporary stack (hibernation).
> Replace local_irq_disable with raw_local_irq_disable instead to
> avoid tracers.
>
> Signed-off-by: Sebastian Capella <sebastian.capella@linaro.org>
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Robin Holt <robin.m.holt@gmail.com>
> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> ---
> arch/arm/kernel/process.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
> index 92f7b15..f58b723 100644
> --- a/arch/arm/kernel/process.c
> +++ b/arch/arm/kernel/process.c
> @@ -100,7 +100,7 @@ void soft_restart(unsigned long addr)
> u64 *stack = soft_restart_stack + ARRAY_SIZE(soft_restart_stack);
>
> /* Disable interrupts first */
> - local_irq_disable();
> + raw_local_irq_disable();
> local_fiq_disable();
Great, I'm happy with this now. I assume that the plan is to submit this
to my patch system when everyone's given their fill of acks?
--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
next prev parent reply other threads:[~2014-02-26 23:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 19:10 [PATCH v4 0/2] hibernation support on ARM Sebastian Capella
2014-02-26 19:10 ` [PATCH v4 1/2] ARM: avoid tracers in soft_restart Sebastian Capella
2014-02-26 23:37 ` Russell King - ARM Linux [this message]
2014-02-27 0:18 ` Sebastian Capella
2014-02-26 19:10 ` [PATCH v4 2/2] ARM hibernation / suspend-to-disk Sebastian Capella
2014-02-26 19:18 ` Russ Dill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140226233744.GG21483@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).