From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] iommu/arm-smmu: Return 0 on unmap failure
Date: Fri, 28 Feb 2014 16:39:28 +0000 [thread overview]
Message-ID: <20140228163927.GD30996@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <1393601830-4677-3-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
On Fri, Feb 28, 2014 at 03:37:10PM +0000, Laurent Pinchart wrote:
> The IOMMU core expects the unmap operation to return the number of bytes
> that have been unmapped or 0 on failure, a negative return value being
> treated like a number of bytes.
Makes sense, thanks. It's a pity we can't propagate the error code.
Will
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> drivers/iommu/arm-smmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
> index c33a310..e7528f0 100644
> --- a/drivers/iommu/arm-smmu.c
> +++ b/drivers/iommu/arm-smmu.c
> @@ -1464,7 +1464,7 @@ static size_t arm_smmu_unmap(struct iommu_domain *domain, unsigned long iova,
>
> ret = arm_smmu_handle_mapping(smmu_domain, iova, 0, size, 0);
> arm_smmu_tlb_inv_context(&smmu_domain->root_cfg);
> - return ret ? ret : size;
> + return ret ? 0 : size;
> }
>
> static phys_addr_t arm_smmu_iova_to_phys(struct iommu_domain *domain,
> --
> 1.8.3.2
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
next prev parent reply other threads:[~2014-02-28 16:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 15:37 [PATCH 0/2] ARM SMMU fixes Laurent Pinchart
2014-02-28 15:37 ` [PATCH 1/2] iommu/arm-smmu: Replace list walk with platform driver data Laurent Pinchart
2014-02-28 16:38 ` Will Deacon
2014-03-02 17:59 ` Laurent Pinchart
2014-02-28 15:37 ` [PATCH 2/2] iommu/arm-smmu: Return 0 on unmap failure Laurent Pinchart
2014-02-28 16:39 ` Will Deacon [this message]
2014-04-02 23:52 ` [PATCH 0/2] ARM SMMU fixes Laurent Pinchart
2014-04-08 13:41 ` Laurent Pinchart
2014-04-08 13:57 ` Marc Zyngier
2014-04-14 16:58 ` Will Deacon
2014-04-15 15:55 ` Laurent Pinchart
2014-04-16 14:22 ` Will Deacon
2014-04-16 14:25 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140228163927.GD30996@mudshark.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).