From: oleg@redhat.com (Oleg Nesterov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 00/14] uprobes: Add uprobes support for ARM
Date: Mon, 3 Mar 2014 21:50:39 +0100 [thread overview]
Message-ID: <20140303205039.GA8949@redhat.com> (raw)
In-Reply-To: <53131DBE.7020500@linaro.org>
On 03/02, David Long wrote:
>
> Oleg,
>
> I've been looking at arch/Kconfig and kernel/trace/Kconfig where they
> deal with uprobes. The relevant items are CONFIG_UPROBES and
> CONFIG_UPROBE_EVENT. It just doesn't look right to me.
Yes, this looks strange. I never understood these dependencies. In fact
I even never tried. And I do not really understand kbuild, unfortunately...
>> --- a/arch/Kconfig
>> +++ b/arch/Kconfig
>> @@ -87,7 +87,8 @@ config KPROBES_ON_FTRACE
>>
>> config UPROBES
>> bool "Transparent user-space probes (EXPERIMENTAL)"
>> - depends on UPROBE_EVENT && PERF_EVENTS
>> + depends on ARCH_SUPPORTS_UPROBES
>> + depends on PERF_EVENTS
And why CONFIG_UPROBES should depend on PERF_EVENTS? uprobes can be
used by (say) systemtap without UPROBE_EVENT/PERF_EVENTS.
But as Russell pointed out the events directory is only built if
CONFIG_PERF_EVENTS=y, so it should depend on it or select...
I dunno. Personally I vote for the patch from Srikar in
http://article.gmane.org/gmane.linux.kernel/1017186
This is what we currently have, currently CONFIG_UPROBES is not
user-selectable anyway.
Oleg.
next prev parent reply other threads:[~2014-03-03 20:50 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 7:38 [PATCH v6 00/14] uprobes: Add uprobes support for ARM David Long
2014-02-10 7:38 ` [PATCH v6 01/14] uprobes: allow ignoring of probe hits David Long
2014-02-10 7:38 ` [PATCH v6 02/14] ARM: move shared uprobe/kprobe definitions into new include file David Long
2014-02-10 7:38 ` [PATCH v6 03/14] ARM: Move generic arm instruction parsing code to new files for sharing between features David Long
2014-02-10 7:38 ` [PATCH v6 04/14] ARM: move generic thumb instruction parsing code to new files for use by other feature David Long
2014-02-10 7:38 ` [PATCH v6 05/14] ARM: use a function table for determining instruction interpreter action David Long
2014-02-10 7:38 ` [PATCH v6 06/14] ARM: Disable jprobes test when built into thumb-mode kernel David Long
2014-02-10 7:38 ` [PATCH v6 07/14] ARM: Remove use of struct kprobe from generic probes code David Long
2014-02-28 10:12 ` Russell King - ARM Linux
2014-02-28 14:11 ` Jon Medhurst (Tixy)
2014-02-28 14:45 ` Jon Medhurst (Tixy)
2014-03-02 10:37 ` David Long
2014-03-02 12:11 ` Russell King - ARM Linux
2014-02-10 7:38 ` [PATCH v6 08/14] ARM: Make the kprobes condition_check symbol names more generic David Long
2014-02-10 7:39 ` [PATCH v6 09/14] ARM: Change more ARM kprobes symbol names to something more David Long
2014-02-10 7:39 ` [PATCH v6 10/14] ARM: Rename the shared kprobes/uprobe return value enum David Long
2014-02-10 7:39 ` [PATCH v6 11/14] ARM: Change the remaining shared kprobes/uprobes symbols to something generic David Long
2014-02-10 7:39 ` [PATCH v6 12/14] ARM: Add an emulate flag to the kprobes/uprobes instruction decode functions David Long
2014-02-10 7:39 ` [PATCH v6 13/14] ARM: Make arch_specific_insn a define for new arch_probes_insn structure David Long
2014-02-10 7:39 ` [PATCH v6 14/14] ARM: add uprobes support David Long
2014-03-01 12:30 ` [PATCH v6 00/14] uprobes: Add uprobes support for ARM Russell King - ARM Linux
2014-03-02 12:02 ` David Long
2014-03-03 6:23 ` Srikar Dronamraju
2014-03-03 10:08 ` David Long
2014-03-03 10:39 ` Russell King - ARM Linux
2014-03-03 20:50 ` Oleg Nesterov [this message]
2014-03-04 0:53 ` Russell King - ARM Linux
2014-03-04 17:31 ` Oleg Nesterov
2014-03-06 8:10 ` David Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140303205039.GA8949@redhat.com \
--to=oleg@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).