From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] mfd: mc13xxx: Honor designed SPI mode
Date: Tue, 4 Mar 2014 21:13:12 +0100 [thread overview]
Message-ID: <20140304201312.GR17250@pengutronix.de> (raw)
In-Reply-To: <1393840265.156525459@f373.i.mail.ru>
On Mon, Mar 03, 2014 at 01:51:05PM +0400, Alexander Shiyan wrote:
> ???????????, 3 ????? 2014, 10:41 +01:00 ?? Sascha Hauer <s.hauer@pengutronix.de>:
> > On Sun, Mar 02, 2014 at 11:44:32AM +0400, Alexander Shiyan wrote:
> > > Instead of using hard coded SPI mode, use mode described in
> > > devicetree or defined for the board.
> > > Additionally, patch updates all users of this PMIC to use
> > > correct SPI mode.
> >
> > What's the reason for this change? Without it the driver just does the
> > correct thing, this only adds a chance for boards do get it wrong. This
> > for example happens with the i.MX27 phyCORE in this patch, see
> > happens with arch/arm/boot/dts/imx27-phytec-phycore-som.dts whih doesn't
> > have the spi-cs-high property.
>
> How specify proper functionality if chipselect connected through inverter?
Is there such a hardware around?
>
> For i.MX27 phyCORE:
> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/arch/arm/boot/dts/imx27-phytec-phycore-som.dtsi?id=986cc4920412d8a7b5c9dba85601651f6373f45e
Ok, I missed that one.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2014-03-04 20:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-02 7:44 [PATCH 1/4] mfd: mc13xxx: Honor designed SPI mode Alexander Shiyan
2014-03-02 7:44 ` [PATCH 2/4] mfd: mc13xxx: Limit maximum SPI speed Alexander Shiyan
2014-03-03 7:36 ` Lee Jones
2014-03-02 7:44 ` [PATCH 3/4] mfd: mc13xxx: Add missing spi_setup() Alexander Shiyan
2014-03-03 7:37 ` Lee Jones
2014-03-02 7:44 ` [PATCH 4/4] regulator: mc13xxx: Fix probing with DT Alexander Shiyan
2014-03-03 1:58 ` Mark Brown
2014-03-03 7:35 ` [PATCH 1/4] mfd: mc13xxx: Honor designed SPI mode Lee Jones
2014-03-03 7:55 ` Alexander Shiyan
2014-03-03 9:23 ` Lee Jones
2014-03-03 9:41 ` Sascha Hauer
2014-03-03 9:51 ` Alexander Shiyan
2014-03-04 20:13 ` Sascha Hauer [this message]
2014-03-04 20:51 ` Alexander Shiyan
2014-03-05 11:57 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140304201312.GR17250@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).