From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC 3/6] tty: Rename xilinx_uart -> cadence_uart
Date: Tue, 4 Mar 2014 23:16:26 +0100 [thread overview]
Message-ID: <201403042316.26221.arnd@arndb.de> (raw)
In-Reply-To: <20140304193913.71c6f307@alan.etchedpixels.co.uk>
On Tuesday 04 March 2014, One Thousand Gnomes wrote:
> On Tue, 4 Mar 2014 09:17:26 -0800
> Soren Brinkmann <soren.brinkmann@xilinx.com> wrote:
> The following aspects of the change set are IMHO acceptable
>
> - Cleaning up all the code formatting
> - Update the driver comments and header to explain the Cadence/Xilinx
> thing
> - change "Xilinx PS UART Support" text to "Cadence (Xilinx PS) Support"
> or similar wording in Kconfig
> - Adding the cadence devicetree compatibility strings and inputs *in
> addition* to the existing ones.
> - Documentation for the new options
I agree. I think it would also be nice to allow the standard clock names
to be used as an alternative to the bogus ref_clk" and "aper_clk"
names, but just like the compatible string, it's too late to remove
support for the existing ones.
Regarding the "xlnx,xuartps" compatible string, even if we were to break
backwards comptibility with the clocks, I would still want to see this
string being used in addition to "cdns,uart-r1p8" so we have a way to
detect possible changes that xilinx did on top of the r1p8 version.
I also wonder if "cdns,uart-r1p8" is actually specific enough: r1p8
looks like a version number rather than a name, and it seems possible
that Cadence has produced more than one uart implemention in the past
or will do another one in the future that is not just a different
revision of this one but instead something completely different.
Arnd
next prev parent reply other threads:[~2014-03-04 22:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 17:17 [PATCH RFC 0/6] tty: xuartps renaming Soren Brinkmann
2014-03-04 17:17 ` [PATCH RFC 1/6] tty: xemacps: Clean up Soren Brinkmann
2014-03-04 17:17 ` [PATCH RFC 2/6] tty: xemacps: Print warning in clock notifier Soren Brinkmann
2014-03-04 17:17 ` [PATCH RFC 3/6] tty: Rename xilinx_uart -> cadence_uart Soren Brinkmann
2014-03-04 19:39 ` One Thousand Gnomes
2014-03-04 22:16 ` Arnd Bergmann [this message]
2014-03-05 18:22 ` Sören Brinkmann
2014-03-04 17:17 ` [PATCH RFC 4/6] tty: cadence: Document DT binding Soren Brinkmann
2014-03-04 17:17 ` [PATCH RFC 5/6] ARM: zynq: DT: Migrate UART to Cadence binding Soren Brinkmann
2014-03-04 17:17 ` [PATCH RFC 6/6] ARM: multi_v7_defconfig: Adopt to UART driver renaming Soren Brinkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201403042316.26221.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).