From: simon.kagstrom@netinsight.net (Simon Kågström)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/2]: ixp4xx: Fix 3.7 regression for IXP4xx ethernet driver
Date: Wed, 5 Mar 2014 08:53:11 +0100 [thread overview]
Message-ID: <20140305085311.07b3922a@marrow.netinsight.se> (raw)
Hi!
These two patches fixes the regression introduced in 3.7 by commit
1a4901177574083c35fafc24c4d151c2a7c7647c,
ixp4xx_eth: avoid calling dma_pool_create() with NULL dev
The patch above is not incorrect itself, but causes the driver to fail
with
[ 33.055473] net eth1: coherent DMA mask is unset
[ 33.055523] net eth1: coherent allocation too big (requested 0x1000 mask 0x0)
The two patches fix this by generalizing and correcting the ixp4xx
dma_set_coherent_mask(), which earlier only dealt with the PCI case.
The second patch simply sets up the mask for the ixp4xx ethernet device.
The patches have been verified on a board with 256MiB memory, one
ipx4xx_eth device and a e100 PCI device, running Linus' tip.
This issue has been discussed before:
https://lkml.org/lkml/2014/1/2/46
http://lists.infradead.org/pipermail/linux-arm-kernel/2013-February/148811.html
// Simon
next reply other threads:[~2014-03-05 7:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 7:53 Simon Kågström [this message]
2014-03-05 7:55 ` [PATCH 1/2] ARM: ixp4xx: Make dma_set_coherent_mask common, correct implementation Simon Kågström
2014-03-05 7:55 ` [PATCH 2/2] ixp4xx_eth: Setup coherent_dma_mask Simon Kågström
2014-03-05 9:21 ` Krzysztof Hałasa
2014-03-05 9:43 ` Russell King - ARM Linux
2014-03-05 9:55 ` Krzysztof Hałasa
2014-03-05 10:07 ` Simon Kågström
2014-03-05 10:12 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140305085311.07b3922a@marrow.netinsight.se \
--to=simon.kagstrom@netinsight.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox