linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] clk: turn rate change failed warning into pr_debug
@ 2014-01-16 15:12 Sascha Hauer
  2014-03-05 11:28 ` Sascha Hauer
  0 siblings, 1 reply; 3+ messages in thread
From: Sascha Hauer @ 2014-01-16 15:12 UTC (permalink / raw)
  To: linux-arm-kernel

If a rate change failed it's the opportunity of the caller to handle
this. Do not spam the log with a message.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Mike Turquette <mturquette@linaro.org>
Cc: linux-arm-kernel at lists.infradead.org
Cc: linux-kernel at vger.kernel.org
---
 drivers/clk/clk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 2cf2ea6..f0124d4 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -1460,7 +1460,7 @@ int clk_set_rate(struct clk *clk, unsigned long rate)
 	/* notify that we are about to change rates */
 	fail_clk = clk_propagate_rate_change(top, PRE_RATE_CHANGE);
 	if (fail_clk) {
-		pr_warn("%s: failed to set %s rate\n", __func__,
+		pr_debug("%s: failed to set %s rate\n", __func__,
 				fail_clk->name);
 		clk_propagate_rate_change(top, ABORT_RATE_CHANGE);
 		ret = -EBUSY;
-- 
1.8.5.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] clk: turn rate change failed warning into pr_debug
  2014-01-16 15:12 [PATCH] clk: turn rate change failed warning into pr_debug Sascha Hauer
@ 2014-03-05 11:28 ` Sascha Hauer
  2014-03-21  0:09   ` Mike Turquette
  0 siblings, 1 reply; 3+ messages in thread
From: Sascha Hauer @ 2014-03-05 11:28 UTC (permalink / raw)
  To: linux-arm-kernel

Mike,

Any objections to this patch?

Sascha

On Thu, Jan 16, 2014 at 04:12:55PM +0100, Sascha Hauer wrote:
> If a rate change failed it's the opportunity of the caller to handle
> this. Do not spam the log with a message.
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Mike Turquette <mturquette@linaro.org>
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linux-kernel at vger.kernel.org
> ---
>  drivers/clk/clk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index 2cf2ea6..f0124d4 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -1460,7 +1460,7 @@ int clk_set_rate(struct clk *clk, unsigned long rate)
>  	/* notify that we are about to change rates */
>  	fail_clk = clk_propagate_rate_change(top, PRE_RATE_CHANGE);
>  	if (fail_clk) {
> -		pr_warn("%s: failed to set %s rate\n", __func__,
> +		pr_debug("%s: failed to set %s rate\n", __func__,
>  				fail_clk->name);
>  		clk_propagate_rate_change(top, ABORT_RATE_CHANGE);
>  		ret = -EBUSY;
> -- 
> 1.8.5.2
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] clk: turn rate change failed warning into pr_debug
  2014-03-05 11:28 ` Sascha Hauer
@ 2014-03-21  0:09   ` Mike Turquette
  0 siblings, 0 replies; 3+ messages in thread
From: Mike Turquette @ 2014-03-21  0:09 UTC (permalink / raw)
  To: linux-arm-kernel

Quoting Sascha Hauer (2014-03-05 03:28:28)
> Mike,
> 
> Any objections to this patch?

None at all. Taken into clk-next.

Thanks,
Mike

> 
> Sascha
> 
> On Thu, Jan 16, 2014 at 04:12:55PM +0100, Sascha Hauer wrote:
> > If a rate change failed it's the opportunity of the caller to handle
> > this. Do not spam the log with a message.
> > 
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > Cc: Mike Turquette <mturquette@linaro.org>
> > Cc: linux-arm-kernel at lists.infradead.org
> > Cc: linux-kernel at vger.kernel.org
> > ---
> >  drivers/clk/clk.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> > index 2cf2ea6..f0124d4 100644
> > --- a/drivers/clk/clk.c
> > +++ b/drivers/clk/clk.c
> > @@ -1460,7 +1460,7 @@ int clk_set_rate(struct clk *clk, unsigned long rate)
> >       /* notify that we are about to change rates */
> >       fail_clk = clk_propagate_rate_change(top, PRE_RATE_CHANGE);
> >       if (fail_clk) {
> > -             pr_warn("%s: failed to set %s rate\n", __func__,
> > +             pr_debug("%s: failed to set %s rate\n", __func__,
> >                               fail_clk->name);
> >               clk_propagate_rate_change(top, ABORT_RATE_CHANGE);
> >               ret = -EBUSY;
> > -- 
> > 1.8.5.2
> > 
> > 
> 
> -- 
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-03-21  0:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-16 15:12 [PATCH] clk: turn rate change failed warning into pr_debug Sascha Hauer
2014-03-05 11:28 ` Sascha Hauer
2014-03-21  0:09   ` Mike Turquette

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).