From mboxrd@z Thu Jan 1 00:00:00 1970 From: s.hauer@pengutronix.de (Sascha Hauer) Date: Wed, 5 Mar 2014 12:48:43 +0100 Subject: [PATCH] ARM: i.MX: mx21ads: Replace direct handling of peripheral bits with GPIOs In-Reply-To: <20140305070147.GL8784@S2101-09.ap.freescale.net> References: <1393871864-25223-1-git-send-email-shc_work@mail.ru> <20140305055634.GG8784@S2101-09.ap.freescale.net> <1394002407.236079875@f309.i.mail.ru> <20140305070147.GL8784@S2101-09.ap.freescale.net> Message-ID: <20140305114843.GT17250@pengutronix.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Mar 05, 2014 at 03:01:49PM +0800, Shawn Guo wrote: > On Wed, Mar 05, 2014 at 10:53:27AM +0400, Alexander Shiyan wrote: > > ?????, 5 ????? 2014, 13:56 +08:00 ?? Shawn Guo : > > > On Mon, Mar 03, 2014 at 10:37:44PM +0400, Alexander Shiyan wrote: > > > > This patch replaces direct handling of peripheral bits with GPIOs by > > > > using basic-mmio-gpio driver. As a result this change eliminate some > > > > low-level code and removes custom io_map() from the board. > > > > > > > > Signed-off-by: Alexander Shiyan > > > > --- > > > > arch/arm/mach-imx/mach-mx21ads.c | 136 +++++++++++++++++++-------------------- > > > > 1 file changed, 66 insertions(+), 70 deletions(-) > > > > > > I'm generally not fond of taking patches that touch the legacy board > > > file unless they're fixing or cleaning up something. Since it looks > > > like a cleanup, I will probably take it. But did you test the change on > > > hardware? > > > > No. Unfortunately I do not have this board. Similar change I did for the > > other subarch, and it has been tested > > (https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/arch/arm/mach-clps711x/board-p720t.c?id=6d640edeb598dd76c64aa99357d9b59996dcb3bc). > > > > Yes, it is mostly cleanup. The next change to this board will introduce GPIO > > regulator (based on this change) for the framebuffer, it will help to remove > > ".init" and ".exit" hooks for the imxfb driver. > > Ok, fare enough. Sascha? Acked-by: Sascha Hauer Unfortunately I don't have this hardware either. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |