linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 02/12] phy: omap-control: Update DT binding information
Date: Wed, 5 Mar 2014 08:26:42 -0800	[thread overview]
Message-ID: <20140305162642.GA4983@atomide.com> (raw)
In-Reply-To: <5317172A.1050803@ti.com>

* Roger Quadros <rogerq@ti.com> [140305 04:26]:
> + George
> 
> Tony,
> 
> On 03/04/2014 06:28 PM, Tony Lindgren wrote:
> > * Roger Quadros <rogerq@ti.com> [140304 01:17]:
> >> Hi Tony,
> >>
> >> On 03/03/2014 09:02 PM, Tony Lindgren wrote:
> >>> * Roger Quadros <rogerq@ti.com> [140303 07:10]:
> >>>> Move omap-control binding information to the right location.
> >>>>
> >>>> Signed-off-by: Roger Quadros <rogerq@ti.com>
> >>>> ---
> >>>>  Documentation/devicetree/bindings/phy/ti-phy.txt   | 25 ++++++++++++++++++++++
> >>>>  Documentation/devicetree/bindings/usb/omap-usb.txt | 24 ---------------------
> >>>>  2 files changed, 25 insertions(+), 24 deletions(-)
> >>>>
> >>>> diff --git a/Documentation/devicetree/bindings/phy/ti-phy.txt b/Documentation/devicetree/bindings/phy/ti-phy.txt
> >>>> index 207e14c..41dc132 100644
> >>>> --- a/Documentation/devicetree/bindings/phy/ti-phy.txt
> >>>> +++ b/Documentation/devicetree/bindings/phy/ti-phy.txt
> >>>> @@ -1,5 +1,30 @@
> >>>>  TI PHY: DT DOCUMENTATION FOR PHYs in TI PLATFORMs
> >>>>  
> >>>> +OMAP CONTROL PHY
> >>>> +
> >>>> +Required properties:
> >>>> + - compatible: Should be one of
> >>>> + "ti,control-phy-otghs" - if it has otghs_control mailbox register as on OMAP4.
> >>>> + "ti,control-phy-usb2" - if it has Power down bit in control_dev_conf register
> >>>> +                        e.g. USB2_PHY on OMAP5.
> >>>> + "ti,control-phy-pipe3" - if it has DPLL and individual Rx & Tx power control
> >>>> +                        e.g. USB3 PHY and SATA PHY on OMAP5.
> >>>> + "ti,control-phy-dra7usb2" - if it has power down register like USB2 PHY on
> >>>> +                        DRA7 platform.
> >>>> + "ti,control-phy-am437usb2" - if it has power down register like USB2 PHY on
> >>>> +                        AM437 platform.
> >>>
> >>> To me it seems that you can leave out all the above. You can set these falgs
> >>> flags directly in the driver based on the compatible flag. Then just initialize
> >>> the .data in the driver based on the compatible flag.
> >>
> >> I'm not sure if I got you. A single platform can have different type of phys.
> >>
> >> e.g. OMAP5 has both usb2 and pipe3 PHYs,
> >> DRA7 has both pipe3 and usb2 PHYs, but this usb2 PHY is not compatible with OMAP5 one
> >> so we need a new compatible id for that.
> >>
> >> To add to the woes, the designers were creative enough to make another mutation to
> >> the USB2 PHY for AM437x, :(
> > 
> > Oh OK, in that case the compatible flag may not be enough for configuring the
> > various instances.
> >  
> >> What do you suggest the compatible ids should look like for these 5 types of PHY control?
> >> OTGHS	(OMAP4 & 5)
> >> USB2	(OMAP5)
> >> PIPE3	(OMAP5 & DRA7)
> >> USB2x	(DRA7)
> >> USB2y	(AM437)
> > 
> > I think in that case having the various instances fully configurable from
> > device tree is OK if you prefer that. But if you wanted to use the
> > compatible flag, then you could do something like this:
> > 
> > ti,control-phy-omap4-otghs	(assuming same on omap4 & 5)
> > ti,control-phy-omap5-usb2
> > ti,control-phy-omap5-pipe3	(assuming same on omap5 & dra7)
> > ti,control-phy-dra7-usb2x
> > ti,control-phy-am437-usb2y
> > ...
> > 
> 
> Please note that the original bindings were added in v3.13 and I'm just moving the documentation
> to the right location. So I don't think we should change the bindings now.

OK yeah if the bindings are established you should keep them around.
 
> "ti,control-phy-dra7usb2" and "ti,control-phy-am437usb2" have no users still so we could probably
> change those to "ti,control-phy-dra7-usb2" and "ti,control-phy-am437-usb2".
> 
> What do you say?

Makes sense to me.

Regards,

Tony

  reply	other threads:[~2014-03-05 16:26 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-03 15:07 [PATCH 00/12] ARM: OMAP: SATA support for OMAP5 & DRA7 Roger Quadros
2014-03-03 15:07 ` [PATCH 01/12] phy: rename struct omap_control_usb to struct omap_control_phy Roger Quadros
2014-03-04  9:26   ` Kishon Vijay Abraham I
2014-03-03 15:07 ` [PATCH 02/12] phy: omap-control: Update DT binding information Roger Quadros
2014-03-03 19:02   ` Tony Lindgren
2014-03-04  9:14     ` Roger Quadros
2014-03-04 16:28       ` Tony Lindgren
2014-03-05 10:37         ` Roger Quadros
2014-03-05 12:23         ` Roger Quadros
2014-03-05 16:26           ` Tony Lindgren [this message]
2014-03-03 15:07 ` [PATCH 03/12] phy: ti-pipe3: cleanup clock handling Roger Quadros
2014-03-04  9:29   ` Kishon Vijay Abraham I
2014-03-04  9:33     ` Roger Quadros
2014-03-03 15:07 ` [PATCH 04/12] ARM: dts: omap5: Add clocks to usb3_phy node Roger Quadros
2014-03-03 15:07 ` [PATCH 05/12] phy: ti-pipe3: Add SATA DPLL support Roger Quadros
2014-03-03 15:07 ` [PATCH 06/12] phy: omap: Select OMAP_OCP2SCP bus driver Roger Quadros
2014-03-03 18:52   ` Tony Lindgren
2014-03-04  9:21     ` Roger Quadros
2014-03-03 15:07 ` [PATCH 07/12] ARM: OMAP5: hwmod: Add ocp2scp3 and sata hwmods Roger Quadros
2014-03-03 15:07 ` [PATCH 08/12] ARM: dts: omap5: add sata node Roger Quadros
2014-03-03 15:07 ` [PATCH 09/12] phy: ti-pipe3: streamline PHY operations Roger Quadros
2014-03-03 15:07 ` [PATCH 10/12] phy: ti-pipe3: Fix suspend/resume and module reload Roger Quadros
2014-03-03 15:07 ` [PATCH 11/12] ARM: DRA7: hwmod: Add ocp2scp3 and sata hwmods Roger Quadros
2014-03-03 15:07 ` [PATCH 12/12] ARM: dts: dra7: add OCP2SCP3 and SATA nodes Roger Quadros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140305162642.GA4983@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).