linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 4/7] ARM: dts: omap3-overo: Add HSUSB PHY
Date: Wed, 5 Mar 2014 11:39:03 -0800	[thread overview]
Message-ID: <20140305193903.GB7599@atomide.com> (raw)
In-Reply-To: <5316D9D7.9070100@epfl.ch>

* Florian Vaussard <florian.vaussard@epfl.ch> [140305 00:04]:
> On 03/03/2014 02:07 PM, Roger Quadros wrote:
> > 
> > Putting usb host pins in omap3-overo.dtsi implies that all Overo expansion boards will use it
> > but that is not always the case. Any expansion board vendor can decide not to use USB host feature.
> > 
> 
> I do agree that this can be the case. So it makes sense to push the
> USB host down to expansion boards.
> 
> Now how to do it? The omap3_pmx_core part can be put in
> omap3-overo-tobi-common.dtsi. But unfortunately, the omap3_pmx_core2
> part cannot
> be factorized between the two variants, as one has to use a different
> macro for each case (OMAP3430_CORE2_IOPAD vs. OMAP3630_CORE2_IOPAD).
> Including the right .dtsi file is not enough.

FYI, it's best to have the mux registers board specific and separate
because the mux settings can depend on the SoC revision or even
packaging.
 
> As it can be seen from include/dt-bindings/pinctrl/omap.h, even if the
> padconf register physical address is identical for both SoCs, the offset
> inside omap3_pmx_core2 will be different (as the start of
> omap3_pmx_core2 is 0x480025d8 for omap34xx and 0x480025a0 for omap36xx).
> 
> Thus the pins belonging to omap3_pmx_core2 must be in a SoC-dependent
> .dtsi file.

It seems we need a top level .dts file incuding the right SoC and
pinconf settings.
 
> I will post a v4 with a new proposition. Thanks for your inputs.

OK as that might change the other patches too let's wait for that.

Regards,

Tony

  reply	other threads:[~2014-03-05 19:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-03  9:34 [PATCH v3 0/7] ARM: dts: Better support for Gumstix Overo (for 3.15?) Florian Vaussard
2014-03-03  9:34 ` [PATCH v3 1/7] ARM: dts: omap3-tobi: Add missing pinctrl Florian Vaussard
2014-03-03  9:34 ` [PATCH v3 2/7] ARM: dts: omap3-overo: " Florian Vaussard
2014-03-03  9:34 ` [PATCH v3 3/7] ARM: dts: omap3-overo: Enable WiFi/BT combo Florian Vaussard
2014-03-03  9:34 ` [PATCH v3 4/7] ARM: dts: omap3-overo: Add HSUSB PHY Florian Vaussard
2014-03-03 11:03   ` Roger Quadros
2014-03-03 12:48     ` Florian Vaussard
2014-03-03 13:07       ` Roger Quadros
2014-03-05  8:01         ` Florian Vaussard
2014-03-05 19:39           ` Tony Lindgren [this message]
2014-03-07 15:31           ` Florian Vaussard
2014-03-03  9:34 ` [PATCH v3 5/7] ARM: dts: omap: Add common file for SMSC9221 Florian Vaussard
2014-03-03  9:34 ` [PATCH v3 6/7] ARM: dts: omap3-tobi: Use include file omap-gpmc-smsc9221 Florian Vaussard
2014-03-03  9:34 ` [PATCH v3 7/7] ARM: dts: omap3-tobi: Add AT24C01 EEPROM Florian Vaussard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140305193903.GB7599@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).