From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] perf tests: Introduce perf_regs_load function on ARM
Date: Thu, 6 Mar 2014 11:33:15 +0000 [thread overview]
Message-ID: <20140306113314.GD5202@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <CAFrcx1=3+zZPErXC7dehwpKHnmwE=cWh1mR0kzN0PONpFZKaUw@mail.gmail.com>
On Wed, Mar 05, 2014 at 02:17:00AM +0000, Jean Pihet wrote:
> On 4 March 2014 12:00, Will Deacon <will.deacon@arm.com> wrote:
> > On Mon, Mar 03, 2014 at 09:53:21AM +0000, Jean Pihet wrote:
> >> + str lr, [r0, #PC] @ Save caller PC
> >
> > This isn't necessarily the `caller PC' (depending on how you define it).
> > It's the return address, which is probably (but not always) the instruction
> > following the branch to this function.
> Agreed. However the perf test code expects a registers buffer filled
> in with the caller's values.
> I can change the comment here, is that needed?
It depends what the perf test code really expects. At the moment, you're not
providing it with anything consistent which doesn't sound correct.
What does it use the caller PC for?
Will
next prev parent reply other threads:[~2014-03-06 11:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-03 9:53 [PATCH 0/3] perf tools: Add libdw DWARF post unwind support for ARM Jean Pihet
2014-03-03 9:53 ` [PATCH 1/3] perf tests: Introduce perf_regs_load function on ARM Jean Pihet
2014-03-04 7:50 ` Jean Pihet
2014-03-04 7:57 ` Jean Pihet
2014-03-04 11:00 ` Will Deacon
2014-03-05 2:17 ` Jean Pihet
2014-03-06 11:33 ` Will Deacon [this message]
2014-03-06 17:22 ` Jiri Olsa
2014-03-11 18:25 ` Jean Pihet
2014-03-12 16:13 ` Will Deacon
2014-03-03 9:53 ` [PATCH 2/3] perf tests: Add dwarf unwind test " Jean Pihet
2014-03-03 9:53 ` [PATCH 3/3] perf tools: Add libdw DWARF post unwind support for ARM Jean Pihet
2014-03-04 1:24 ` [PATCH 0/3] " Jean Pihet
2014-03-04 10:37 ` Jiri Olsa
2014-03-04 11:58 ` Jiri Olsa
-- strict thread matches above, loose matches on Subject: below --
2014-05-06 15:26 Jean Pihet
2014-05-06 15:26 ` [PATCH 1/3] perf tests: Introduce perf_regs_load function on ARM Jean Pihet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140306113314.GD5202@mudshark.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).