From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-sunxi] Re: [PATCH v3 1/5] i2c: mv64xxx: Add reset deassert call
Date: Fri, 7 Mar 2014 12:18:58 +0100 [thread overview]
Message-ID: <20140307111858.GB12274@katana> (raw)
In-Reply-To: <CAGb2v66xViOx+DdnuDwad0HsCx2YiYfxqBDAEwYdLHrSydOj0w@mail.gmail.com>
> > Since RESET_CONTROLLER is not required for those platforms, it really
> > should be optional - and I think the real fix is for the reset controller
> > support to provide stub functions.
>
> Philipp Zabel suggested that adding a _optional variant that provides stubs
> and doesn't depend on RESET_CONTROLLER is probably better. This keeps the
> compile time checks for drivers requiring it.
>
> See: https://lkml.org/lkml/2014/1/10/220
>
> I ended up dropping my patch though.
Thanks for the pointer. Well, looks like I need to revert the offending
i2c patches then until this issue is fixed? We can't have
RESET_CONTROLLER (circular dependency) and we can't skip it (build
failures).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140307/7a5dc2eb/attachment.sig>
next prev parent reply other threads:[~2014-03-07 11:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 16:28 [PATCH v3 0/5] ARM: sun6i: Add support for the A31 I2C controller Maxime Ripard
2014-03-04 16:28 ` [PATCH v3 1/5] i2c: mv64xxx: Add reset deassert call Maxime Ripard
2014-03-05 16:31 ` Wolfram Sang
2014-03-07 9:52 ` Russell King - ARM Linux
2014-03-07 10:07 ` Maxime Ripard
2014-03-07 10:34 ` Russell King - ARM Linux
2014-03-07 10:37 ` Wolfram Sang
2014-03-07 11:11 ` [linux-sunxi] " Chen-Yu Tsai
2014-03-07 11:18 ` Wolfram Sang [this message]
2014-03-07 13:43 ` [PATCH] i2c: mv64xxx: Fix circular dependencies warning and compilation breakage Maxime Ripard
2014-03-07 14:24 ` Wolfram Sang
2014-03-07 14:26 ` Wolfram Sang
2014-03-07 14:48 ` Maxime Ripard
2014-03-07 13:44 ` [linux-sunxi] Re: [PATCH v3 1/5] i2c: mv64xxx: Add reset deassert call Maxime Ripard
2014-03-04 16:28 ` [PATCH v3 2/5] i2c: mv64xxx: Add support for the Allwinner A31 I2C driver Maxime Ripard
2014-03-05 16:34 ` Wolfram Sang
2014-03-07 10:13 ` Maxime Ripard
2014-03-04 16:28 ` [PATCH v3 3/5] ARM: sun6i: Enable the I2C controllers Maxime Ripard
2014-03-04 16:28 ` [PATCH v3 4/5] ARM: sun6i: Enable the I2C muxing options Maxime Ripard
2014-03-04 16:28 ` [PATCH v3 5/5] ARM: sun6i: colombus: Enable the I2C controllers Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140307111858.GB12274@katana \
--to=wsa@the-dreams.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox