public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: Qualcomm PMIC8XXX keypad never worked?
Date: Tue, 11 Mar 2014 12:00:56 +0000	[thread overview]
Message-ID: <20140311120056.GH21216@lee--X1> (raw)
In-Reply-To: <5887114.1jrNo21sGX@wuerfel>

> Something in the MFD_PM8XXX driver must have changed recently that now allows
> the KEYBOARD_PMIC8XXX driver to be enabled. Unfortunately, it does not build
> because of a dependency on the <linux/mfd/pm8xxx/gpio.h> header file that
> does not exist.

I have it?

-rw-r--r-- 1 lee lee 2147 Dec 18 11:52 include/linux/mfd/pm8xxx/core.h

> In order to keep 'make randconfig' working on my test box, I have disabled
> this driver, but it would be nice of someone could have a look into fixing it.

Can you send me the config that breaks please?

> --- a/drivers/input/keyboard/Kconfig
> +++ b/drivers/input/keyboard/Kconfig
> @@ -470,7 +470,7 @@ config KEYBOARD_PXA930_ROTARY
>  
>  config KEYBOARD_PMIC8XXX
>         tristate "Qualcomm PMIC8XXX keypad support"
> -       depends on MFD_PM8XXX
> +       depends on MFD_PM8XXX && BROKEN
>         select INPUT_MATRIXKMAP
>         help
>           Say Y here if you want to enable the driver for the PMIC8XXX
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2014-03-11 12:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-11  8:49 Qualcomm PMIC8XXX keypad never worked? Arnd Bergmann
2014-03-11 12:00 ` Lee Jones [this message]
2014-03-11 12:19   ` Arnd Bergmann
2014-03-11 13:06     ` Lee Jones
2014-03-11 13:20       ` Qualcomm PMIC8xxx " Josh Cartwright
2014-03-11 13:35         ` Lee Jones
2014-03-12  5:18       ` Qualcomm PMIC8XXX " Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140311120056.GH21216@lee--X1 \
    --to=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox